1252782 - can't add a "See Also" to a Chromium bug on bugs.chromium.org

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Since Chromium moved its bug tracking off of code.google.com, I can't add a Chromium Bug as a "See Also".

In particular, if I add 
https://bugs.chromium.org/p/chromium/issues/detail?id=462142
as a "See Also" to bug 1252458, I get the error:

=====
https://bugs.chromium.org/p/chromium/issues/detail?id=462142 is not a valid URL to a bug. See Also URLs should point to one of:

    show_bug.cgi in a Bugzilla installation.
    A bug on launchpad.net.
    An issue on code.google.com.
    A bug on bugs.debian.org.
    An issue in a JIRA installation.
    A ticket in a Trac installation.
    A bug in a MantisBT installation.
    A bug on sourceforge.net.
    An issue/pull request on github.com.
    A question on support.mozilla.org.
    An Aha feature on aha.io.
    An issue on webcompat.com.
    A request on ServiceNow.
=====

Comment 1

[Daniel Holbert [:dholbert]]

glob, perhaps you know how to fix this?  It'd be nice to get this fixed before too long -- it's very useful to be able to declaratively link our bugs to related Chrome bug reports.

Comment 2

[:glob ✱]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> glob, perhaps you know how to fix this?  It'd be nice to get this fixed
> before too long -- it's very useful to be able to declaratively link our
> bugs to related Chrome bug reports.

https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/Bugzilla/BugUrl/Google.pm#L35 needs to be updated to support both domains.

Comment 3

[David Lawrence [:dkl]]

Attachment: 1252782_1.patch

Comment 4

[David Lawrence [:dkl]]

Attachment: 1252782_2.patch

Updated license.

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8732341 [details] [diff] [review]
1252782_2.patch

Review of attachment 8732341 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

::: Bugzilla/BugUrl/Chromium.pm
@@ +42,5 @@
> +    if (!$bug_id) {
> +        ThrowUserError('bug_url_invalid', { url => $value, reason => 'id' });
> +    }
> +
> +    return new URI($value);

possible nit: I think for new code we avoid using old-style constructors, right? fix on commit: URI->new($value);

Comment 6

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   d8e47b7..3af55bf  master -> master