1253374 - (webext-port-blackmenu) [meta] Tracking bug to port Black Menu for Google to Firefox

Status: RESOLVED FIXED

(WebExtensions :: Compatibility, defect, P3)

Description

[Tim Nguyen :ntim]

https://carlosjeurissen.com/black-menu-for-google

The developer of this extension is working on porting its extension to Firefox. This tracking bug tracks all the bugs that need to be fixed.

Comment 1

[Andy McKay]

Based on that both the blockers are fixed... closing. Unless there's something else?

Comment 2

[Vasilica Tamas, QA [:vtamas]]

- Submitted Black Menu for Google webextension ( https://addons.allizom.org/en-US/firefox/addon/black-menu-for-google/ ) running the following steps: https://docs.google.com/document/d/18p87u1ccLjYgMEJAANTttsN2ZHFk7lwTgUZWuXaOF9s/edit 

- But I am unable to install it because seems to be corrupted (even with the xpinstall.signatures.dev-root pref set to true) and the following error is thrown in Browser Console: 

1460105354093	addons.webextension.<unknown>	ERROR	Loading extension 'null': Reading manifest: Error processing commands._execute_browser_action.suggested_key.default: Error processing commands._execute_browser_action.suggested_key.default: String "Alt + B" must match /^(MediaNextTrack|MediaPlayPause|MediaPrevTrack|MediaStop)$/
Log.jsm:751


- This error have started to appear since Bug 1225715 had landed. 

- Regression window:
Last good revision: 584870f1cbc5d060a57e147ce249f736956e2b62
First bad revision: b2a3dc4b161fdfac6db78cc5bbfb1f53a383b65a
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=584870f1cbc5d060a57e147ce249f736956e2b62&tochange=b2a3dc4b161fdfac6db78cc5bbfb1f53a383b65a

Is this a known issue? Or should I file a new bug?

Comment 3

[Andy McKay]

Please file a new bug and cc :mattw on it, sounds like its related to chrome.commands parsing of media keys.

Comment 4

[Vasilica Tamas, QA [:vtamas]]

(In reply to Andy McKay [:andym] from comment #3)
> Please file a new bug and cc :mattw on it, sounds like its related to
> chrome.commands parsing of media keys.

Filed Bug 1263560.

I am marking this bug as Verified since the other issue is tracked separately.

Comment 5

[Tim Nguyen :ntim]

The creator of the extension might have other bugs to file (until the extension fully works), so I'm leaving this open.

Comment 6

[Gregory Pappas [:gregp]]

This extension is listed on addons.mozilla.org and seems actively maintained.