Bug 1253374 (webext-port-blackmenu)

[meta] Tracking bug to port Black Menu for Google to Firefox

REOPENED
Unassigned

Status

defect
P3
normal
REOPENED
3 years ago
9 months ago

People

(Reporter: ntim, Unassigned)

Tracking

(Depends on 2 bugs, {meta})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: triaged)

https://carlosjeurissen.com/black-menu-for-google

The developer of this extension is working on porting its extension to Firefox. This tracking bug tracks all the bugs that need to be fixed.
Depends on: 1253924
Based on that both the blockers are fixed... closing. Unless there's something else?
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
- Submitted Black Menu for Google webextension ( https://addons.allizom.org/en-US/firefox/addon/black-menu-for-google/ ) running the following steps: https://docs.google.com/document/d/18p87u1ccLjYgMEJAANTttsN2ZHFk7lwTgUZWuXaOF9s/edit 

- But I am unable to install it because seems to be corrupted (even with the xpinstall.signatures.dev-root pref set to true) and the following error is thrown in Browser Console: 

1460105354093	addons.webextension.<unknown>	ERROR	Loading extension 'null': Reading manifest: Error processing commands._execute_browser_action.suggested_key.default: Error processing commands._execute_browser_action.suggested_key.default: String "Alt + B" must match /^(MediaNextTrack|MediaPlayPause|MediaPrevTrack|MediaStop)$/
Log.jsm:751


- This error have started to appear since Bug 1225715 had landed. 

- Regression window:
Last good revision: 584870f1cbc5d060a57e147ce249f736956e2b62
First bad revision: b2a3dc4b161fdfac6db78cc5bbfb1f53a383b65a
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=584870f1cbc5d060a57e147ce249f736956e2b62&tochange=b2a3dc4b161fdfac6db78cc5bbfb1f53a383b65a

Is this a known issue? Or should I file a new bug?
Flags: needinfo?(amckay)
Please file a new bug and cc :mattw on it, sounds like its related to chrome.commands parsing of media keys.
Flags: needinfo?(amckay)
(In reply to Andy McKay [:andym] from comment #3)
> Please file a new bug and cc :mattw on it, sounds like its related to
> chrome.commands parsing of media keys.

Filed Bug 1263560.

I am marking this bug as Verified since the other issue is tracked separately.
Status: RESOLVED → VERIFIED
Depends on: 1263560
Depends on: 1190663
Depends on: 1269180
Depends on: 1269181
The creator of the extension might have other bugs to file (until the extension fully works), so I'm leaving this open.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Depends on: 1271354
Whiteboard: triaged
Depends on: 1273087
Depends on: 1273264
Depends on: 1273270
Depends on: 1273281
Depends on: 1215025
Component: WebExtensions: Untriaged → WebExtensions: Compatibility
Priority: -- → P3
Depends on: 1220494
Depends on: 1320543
Depends on: 1458374
Depends on: 1459047
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.