Closed Bug 1269180 Opened 5 years ago Closed 3 years ago

Clean up warnings for ignored Chrome permissions

Categories

(WebExtensions :: General, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED INACTIVE

People

(Reporter: ntim, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: triaged)

- 'chrome://favicon/'
- getFrameId
Possibly related: bug 1268370 is about MatchPattern on chrome.webRequest.
Tim, this report isn't very clear.  MatchPattern deliberately does not support chrome URLs.  And I don't understand what getFrameId means here.  Can you be more clear about what you're trying to do?  Maybe MatchGlobs is what you're looking for?
Status: NEW → UNCONFIRMED
Ever confirmed: false
Flags: needinfo?(ntim.bugs)
(In reply to Andrew Swan [:aswan] from comment #2)
> Tim, this report isn't very clear.  MatchPattern deliberately does not
> support chrome URLs.  And I don't understand what getFrameId means here. 
> Can you be more clear about what you're trying to do?  Maybe MatchGlobs is
> what you're looking for?

Sorry for the confusing report. It seems like the add-on uses this script: https://github.com/Rob--W/chrome-api/blob/master/chrome.tabs.executeScriptInFrame/chrome.tabs.executeScriptInFrame.js

That script uses "getFrameId" in a chrome.extension.getURL call. I'm not quite sure how the script works to be fair (or why the script is being used).
Flags: needinfo?(ntim.bugs)
(In reply to Tim Nguyen :ntim from comment #3)
> (In reply to Andrew Swan [:aswan] from comment #2)
> > Tim, this report isn't very clear.  MatchPattern deliberately does not
> > support chrome URLs.  And I don't understand what getFrameId means here. 
> > Can you be more clear about what you're trying to do?  Maybe MatchGlobs is
> > what you're looking for?
> 
> Sorry for the confusing report. It seems like the add-on uses this script:
> https://github.com/Rob--W/chrome-api/blob/master/chrome.tabs.
> executeScriptInFrame/chrome.tabs.executeScriptInFrame.js
> 
> That script uses "getFrameId" in a chrome.extension.getURL call. I'm not
> quite sure how the script works to be fair (or why the script is being used).

From a quick glance at that code, it looks like it is trying to use webRequest to monitor loading of moz-extensions resources?  Is the current lack of support for that the bug you're trying to report?
If you're reporting something else or if you're not sure, please provide clear steps to reproduce along with the expected and actual results.
Flags: needinfo?(ntim.bugs)
STR:
- Install Black menu for google (see blocking bug for link to the extension)
- open the browser console

AR:
- Various errors from MatchPattern

ER:
- no errors
Flags: needinfo?(ntim.bugs)
Those errors are basically MatchPattern failing for getFrameId and chrome://favicon/
Ah, thanks.
I think there are actually two different things here:
1. Including "chrome://favicon" in permissions in the manifest
2. Trying to use webRequest to monitor an extension resource (ie moz-extension://...)

For #1, that's not a valid URL in Firefox, I'm not sure what we should do with it but perhaps we could report a better error.
#2 is not implemented, I'm inferring from the fact this extension exists that Chrome does permit monitoring chrome-extension:// urls with webRequest.

A third related issue that isn't reported here is bug 1269341
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 1271354
(In reply to Andrew Swan [:aswan] from comment #7)
> I think there are actually two different things here:
> 1. Including "chrome://favicon" in permissions in the manifest
> 2. Trying to use webRequest to monitor an extension resource (ie
> moz-extension://...)

Filed bug 1271354 for the second issue, targeting this bug for just the first issue.
Expected behavior is that when the manifest includes permissions for Chrome-specific URLs, the browser console displays a single meaningful message explaining that those permissions don't apply in Firefox.  And in particular, the browser console does not include an exception or stack trace.
Summary: MatchPattern fails in some cases → Clean up warnings for ignored Chrome permissions
Whiteboard: triaged
No longer blocks: 1271354
Duplicate of this bug: 1273087
Component: WebExtensions: Untriaged → WebExtensions: General
Priority: -- → P5
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INACTIVE
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.