1269180 - Clean up warnings for ignored Chrome permissions

Status: RESOLVED INACTIVE

(WebExtensions :: General, defect, P5)

Description

[Tim Nguyen :ntim]

- 'chrome://favicon/'
- getFrameId

Comment 1

[YUKI "Piro" Hiroshi]

Possibly related: bug 1268370 is about MatchPattern on chrome.webRequest.

Comment 2

[Andrew Swan [:aswan]]

Tim, this report isn't very clear.  MatchPattern deliberately does not support chrome URLs.  And I don't understand what getFrameId means here.  Can you be more clear about what you're trying to do?  Maybe MatchGlobs is what you're looking for?

Comment 3

[Tim Nguyen :ntim]

(In reply to Andrew Swan [:aswan] from comment #2)
> Tim, this report isn't very clear.  MatchPattern deliberately does not
> support chrome URLs.  And I don't understand what getFrameId means here. 
> Can you be more clear about what you're trying to do?  Maybe MatchGlobs is
> what you're looking for?

Sorry for the confusing report. It seems like the add-on uses this script: https://github.com/Rob--W/chrome-api/blob/master/chrome.tabs.executeScriptInFrame/chrome.tabs.executeScriptInFrame.js

That script uses "getFrameId" in a chrome.extension.getURL call. I'm not quite sure how the script works to be fair (or why the script is being used).

Comment 4

[Andrew Swan [:aswan]]

(In reply to Tim Nguyen :ntim from comment #3)
> (In reply to Andrew Swan [:aswan] from comment #2)
> > Tim, this report isn't very clear.  MatchPattern deliberately does not
> > support chrome URLs.  And I don't understand what getFrameId means here. 
> > Can you be more clear about what you're trying to do?  Maybe MatchGlobs is
> > what you're looking for?
> 
> Sorry for the confusing report. It seems like the add-on uses this script:
> https://github.com/Rob--W/chrome-api/blob/master/chrome.tabs.
> executeScriptInFrame/chrome.tabs.executeScriptInFrame.js
> 
> That script uses "getFrameId" in a chrome.extension.getURL call. I'm not
> quite sure how the script works to be fair (or why the script is being used).

From a quick glance at that code, it looks like it is trying to use webRequest to monitor loading of moz-extensions resources?  Is the current lack of support for that the bug you're trying to report?
If you're reporting something else or if you're not sure, please provide clear steps to reproduce along with the expected and actual results.

Comment 5

[Tim Nguyen :ntim]

STR:
- Install Black menu for google (see blocking bug for link to the extension)
- open the browser console

AR:
- Various errors from MatchPattern

ER:
- no errors

Comment 6

[Tim Nguyen :ntim]

Those errors are basically MatchPattern failing for getFrameId and chrome://favicon/

Comment 7

[Andrew Swan [:aswan]]

Ah, thanks.
I think there are actually two different things here:
1. Including "chrome://favicon" in permissions in the manifest
2. Trying to use webRequest to monitor an extension resource (ie moz-extension://...)

For #1, that's not a valid URL in Firefox, I'm not sure what we should do with it but perhaps we could report a better error.
#2 is not implemented, I'm inferring from the fact this extension exists that Chrome does permit monitoring chrome-extension:// urls with webRequest.

A third related issue that isn't reported here is bug 1269341

Comment 8

[Andrew Swan [:aswan]]

(In reply to Andrew Swan [:aswan] from comment #7)
> I think there are actually two different things here:
> 1. Including "chrome://favicon" in permissions in the manifest
> 2. Trying to use webRequest to monitor an extension resource (ie
> moz-extension://...)

Filed bug 1271354 for the second issue, targeting this bug for just the first issue.
Expected behavior is that when the manifest includes permissions for Chrome-specific URLs, the browser console displays a single meaningful message explaining that those permissions don't apply in Firefox.  And in particular, the browser console does not include an exception or stack trace.

Comment 10

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.