Move --disable-shared-js and --disable-export-js to moz.configure

RESOLVED FIXED in Firefox 48

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks 1 bug)

unspecified
mozilla48
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(2 attachments)

No description provided.
Blocks: 1255197
The current discrepancy works because gecko and js don't actually agree
on the meaning of JS_EXPORT_API and JS_PUBLIC_API, but moving the
configure flags that incluences their meaning is going to make them
agree, and that adds a fatal warning when building nsJSPrincipals.cpp
because of the discrepancy.

Review commit: https://reviewboard.mozilla.org/r/39139/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39139/
Attachment #8728798 - Flags: review?(bzbarsky)
Comment on attachment 8728798 [details]
MozReview Request: Bug 1254906 - Change JSPrincipals::dump annotation to match that of JSPrincipals::dump

https://reviewboard.mozilla.org/r/39139/#review35781

Commit message should probably mention that we're making the annotation match the declaration.  Right now it's a bit confusing.
Attachment #8728798 - Flags: review?(bzbarsky) → review+
Comment on attachment 8728799 [details]
MozReview Request: Bug 1254906 - Move --disable-shared-js and --disable-export-js to moz.configure

https://reviewboard.mozilla.org/r/39141/#review35961

::: build/moz.configure/util.configure:81
(Diff revision 1)
> +# Denotes a deprecated option. Combines option() and @depends:
> +# @deprecated_option('--option')

A short description of the behavior of this would be helpful.
Attachment #8728799 - Flags: review?(cmanchester) → review+
https://hg.mozilla.org/mozilla-central/rev/488a4c265147
https://hg.mozilla.org/mozilla-central/rev/a69518e297f1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.