1254906 - Move --disable-shared-js and --disable-export-js to moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1254906 - Change JSPrincipals::dump annotation to match that of JSPrincipals::dump

The current discrepancy works because gecko and js don't actually agree
on the meaning of JS_EXPORT_API and JS_PUBLIC_API, but moving the
configure flags that incluences their meaning is going to make them
agree, and that adds a fatal warning when building nsJSPrincipals.cpp
because of the discrepancy.

Review commit: https://reviewboard.mozilla.org/r/39139/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39139/

Comment 2

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1254906 - Move --disable-shared-js and --disable-export-js to moz.configure

Review commit: https://reviewboard.mozilla.org/r/39141/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39141/

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8728798 [details]
MozReview Request: Bug 1254906 - Change JSPrincipals::dump annotation to match that of JSPrincipals::dump

https://reviewboard.mozilla.org/r/39139/#review35781

Commit message should probably mention that we're making the annotation match the declaration.  Right now it's a bit confusing.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8728799 [details]
MozReview Request: Bug 1254906 - Move --disable-shared-js and --disable-export-js to moz.configure

https://reviewboard.mozilla.org/r/39141/#review35961

::: build/moz.configure/util.configure:81
(Diff revision 1)
> +# Denotes a deprecated option. Combines option() and @depends:
> +# @deprecated_option('--option')

A short description of the behavior of this would be helpful.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/488a4c265147
https://hg.mozilla.org/integration/mozilla-inbound/rev/a69518e297f1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/488a4c265147
https://hg.mozilla.org/mozilla-central/rev/a69518e297f1