1255185 - Move --with-external-source-dir to moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1255185 - Move --with-external-source-dir to moz.configure

Review commit: https://reviewboard.mozilla.org/r/38997/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38997/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8728633 [details]
MozReview Request: Bug 1255185 - Move --with-external-source-dir to moz.configure

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38997/diff/1-2/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8728633 [details]
MozReview Request: Bug 1255185 - Move --with-external-source-dir to moz.configure

https://reviewboard.mozilla.org/r/38997/#review35705

::: old-configure.in
(Diff revision 2)
> -  if test ! -f "${srcdir}/${MOZ_BUILD_APP}/build.mk" ; then
> -    AC_MSG_RESULT([none])
> -    AC_MSG_ERROR([--enable-application value not recognized (${MOZ_BUILD_APP}/build.mk does not exist).])
> -  else
> -    AC_MSG_RESULT([$MOZ_BUILD_APP])
> -  fi

I see we didn't port this check... is it obsolete?

Comment 4

[Mike Hommey [:glandium]]

(In reply to Chris Manchester (:chmanchester) from comment #3)
> Comment on attachment 8728633 [details]
> MozReview Request: Bug 1255185 - Move --with-external-source-dir to
> moz.configure
> 
> https://reviewboard.mozilla.org/r/38997/#review35705
> 
> ::: old-configure.in
> (Diff revision 2)
> > -  if test ! -f "${srcdir}/${MOZ_BUILD_APP}/build.mk" ; then
> > -    AC_MSG_RESULT([none])
> > -    AC_MSG_ERROR([--enable-application value not recognized (${MOZ_BUILD_APP}/build.mk does not exist).])
> > -  else
> > -    AC_MSG_RESULT([$MOZ_BUILD_APP])
> > -  fi
> 
> I see we didn't port this check... is it obsolete?

It's covered by requiring a moz.configure file existing in the same directory.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a959b172be4c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a959b172be4c