Move --with-external-source-dir to moz.configure

RESOLVED FIXED in Firefox 48

Status

Firefox Build System
General
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

unspecified
mozilla48
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8728633 [details]
MozReview Request: Bug 1255185 - Move --with-external-source-dir to moz.configure

Review commit: https://reviewboard.mozilla.org/r/38997/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38997/
Attachment #8728633 - Flags: review?(cmanchester)
(Assignee)

Comment 2

2 years ago
Comment on attachment 8728633 [details]
MozReview Request: Bug 1255185 - Move --with-external-source-dir to moz.configure

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38997/diff/1-2/
(Assignee)

Updated

2 years ago
Blocks: 1255197
Comment on attachment 8728633 [details]
MozReview Request: Bug 1255185 - Move --with-external-source-dir to moz.configure

https://reviewboard.mozilla.org/r/38997/#review35705

::: old-configure.in
(Diff revision 2)
> -  if test ! -f "${srcdir}/${MOZ_BUILD_APP}/build.mk" ; then
> -    AC_MSG_RESULT([none])
> -    AC_MSG_ERROR([--enable-application value not recognized (${MOZ_BUILD_APP}/build.mk does not exist).])
> -  else
> -    AC_MSG_RESULT([$MOZ_BUILD_APP])
> -  fi

I see we didn't port this check... is it obsolete?
Attachment #8728633 - Flags: review?(cmanchester) → review+
(Assignee)

Comment 4

2 years ago
(In reply to Chris Manchester (:chmanchester) from comment #3)
> Comment on attachment 8728633 [details]
> MozReview Request: Bug 1255185 - Move --with-external-source-dir to
> moz.configure
> 
> https://reviewboard.mozilla.org/r/38997/#review35705
> 
> ::: old-configure.in
> (Diff revision 2)
> > -  if test ! -f "${srcdir}/${MOZ_BUILD_APP}/build.mk" ; then
> > -    AC_MSG_RESULT([none])
> > -    AC_MSG_ERROR([--enable-application value not recognized (${MOZ_BUILD_APP}/build.mk does not exist).])
> > -  else
> > -    AC_MSG_RESULT([$MOZ_BUILD_APP])
> > -  fi
> 
> I see we didn't port this check... is it obsolete?

It's covered by requiring a moz.configure file existing in the same directory.

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a959b172be4c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.