Closed Bug 1255185 Opened 4 years ago Closed 4 years ago

Move --with-external-source-dir to moz.configure

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8728633 [details]
MozReview Request: Bug 1255185 - Move --with-external-source-dir to moz.configure

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/38997/diff/1-2/
Blocks: 1255197
Comment on attachment 8728633 [details]
MozReview Request: Bug 1255185 - Move --with-external-source-dir to moz.configure

https://reviewboard.mozilla.org/r/38997/#review35705

::: old-configure.in
(Diff revision 2)
> -  if test ! -f "${srcdir}/${MOZ_BUILD_APP}/build.mk" ; then
> -    AC_MSG_RESULT([none])
> -    AC_MSG_ERROR([--enable-application value not recognized (${MOZ_BUILD_APP}/build.mk does not exist).])
> -  else
> -    AC_MSG_RESULT([$MOZ_BUILD_APP])
> -  fi

I see we didn't port this check... is it obsolete?
Attachment #8728633 - Flags: review?(cmanchester) → review+
(In reply to Chris Manchester (:chmanchester) from comment #3)
> Comment on attachment 8728633 [details]
> MozReview Request: Bug 1255185 - Move --with-external-source-dir to
> moz.configure
> 
> https://reviewboard.mozilla.org/r/38997/#review35705
> 
> ::: old-configure.in
> (Diff revision 2)
> > -  if test ! -f "${srcdir}/${MOZ_BUILD_APP}/build.mk" ; then
> > -    AC_MSG_RESULT([none])
> > -    AC_MSG_ERROR([--enable-application value not recognized (${MOZ_BUILD_APP}/build.mk does not exist).])
> > -  else
> > -    AC_MSG_RESULT([$MOZ_BUILD_APP])
> > -  fi
> 
> I see we didn't port this check... is it obsolete?

It's covered by requiring a moz.configure file existing in the same directory.
https://hg.mozilla.org/mozilla-central/rev/a959b172be4c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.