Closed Bug 1255588 Opened 5 years ago Closed 5 years ago

Disable Firefox on MacOS <10.9

Categories

(Core :: Widget: Cocoa, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: benjamin, Assigned: stefanh)

References

Details

Attachments

(3 files, 1 obsolete file)

Announced on firefox-dev, we're planning on dropping support for MacOS versions <10.9. We need to make that explicit in the product so that users get an appropriate error message.
Blocks: 1255589
Depends on: 1269798
We could just use LSMinimumSystemVersion in browser/app/macbuild/Contents/Info.plist.in. Will we support running a 32-bit firefox on 10.9?
Yes, until Firefox 52.
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Yes, until Firefox 52.

Which is weird, because Mac OS X 10.8 requires a 64 bit CPU. IIRC it's why Apple upped the system requirements then, they explicitly left the 32 bit yonah and lower chips behind in 10.7 and earlier.
I pushed a patch to try for a while ago and the 10.7 builders failed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8c12ff4e462&selectedJob=20427468

I guess they launch the application. The 10.7 builders needs to be turned off for 49 or some tests needs to be disabled.
Attached patch Make 10.9.0 the minimum version (obsolete) — Splinter Review
So, this will make Firefox not start if the OS version is < 10.9.0 (tested on 10.7.5)

The logs from the try run also shows that this works:
https://treeherder.mozilla.org/logviewer.html#?job_id=20427356&repo=try#L48239
https://treeherder.mozilla.org/logviewer.html#?job_id=20427356&repo=try#L48268
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #8751452 - Flags: review?(spohl.mozilla.bugs)
(In reply to Stefan [:stefanh] from comment #5)
> Created attachment 8751452 [details] [diff] [review]
> Make 10.9.0 the minimum version
> 
> So, this will make Firefox not start if the OS version is < 10.9.0 (tested
> on 10.7.5)

Can you post a screenshot of what you see when you try to start Firefox on OSX < 10.9.0?
Flags: needinfo?(stefanh)
Whoops, wrong patch.
Attachment #8751452 - Attachment is obsolete: true
Attachment #8751452 - Flags: review?(spohl.mozilla.bugs)
Flags: needinfo?(stefanh)
Attachment #8751453 - Flags: review?(spohl.mozilla.bugs)
(In reply to Stephen A Pohl [:spohl] from comment #6)
> Can you post a screenshot of what you see when you try to start Firefox on
> OSX < 10.9.0?

Sure.
Flags: needinfo?(stefanh)
Attached image 10.7.5-launch.png
Right, I have Swedish version...

Translation:
"This version of the program Nightly can not be used with this version of Mac OS X

You have Mac OS X 10.7.5. The program requires Mac OS X 10.9 or later."
Flags: needinfo?(stefanh)
Comment on attachment 8751453 [details] [diff] [review]
Make 10.9.0 the minimum version v1.0

Review of attachment 8751453 [details] [diff] [review]:
-----------------------------------------------------------------

As discussed via IRC, please don't land this until tests are disabled on OSX < 10.9.0 or you get the green light to land it despite the tests failing. Thanks!
Attachment #8751453 - Flags: review?(spohl.mozilla.bugs) → review+
(In reply to Stefan [:stefanh] from comment #5)
> The logs from the try run also shows that this works:
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=20427356&repo=try#L48239
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=20427356&repo=try#L48268

Hmm, these links doen't seem to work. But this is the message:
13:31:14     INFO - PROCESS | 5887 | application requires at least Mac OS X version 10.9.0, but is being run on 10.7.2, and so is exiting
I just pushed an expanded version of Stefan's patch which disables selftest.py, to see if that will succeed. Ted says we may also run xpcshell as part of package.py (I can't test directly because I no longer have a mac).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=37e0a11521ea
Comment on attachment 8752341 [details] [diff] [review]
try: -b do -p macosx64,macosx64-st-an,macosx64-mulet,macosx64_gecko -u all -t all

Review of attachment 8752341 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/xpcshell/moz.build
@@ +10,5 @@
> +    # Disabled on Mac due to our builders still being on MacOS 10.7,
> +    # see bug 1255588
> +    PYTHON_UNIT_TESTS += [
> +        'selftest.py',
> +    ]

this will remove selftest.py from the 'make check' step of the build job.  from what I can tell this is what we want to do here.
Attachment #8752341 - Flags: review?(jmaher) → review+
I did a try run and everything looks good, but I don't want to land this before the weekend because I won't be around to respond. So I plan on pushing this on Monday unless Stefan you want to do it earlier.
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #15)
> I did a try run and everything looks good, but I don't want to land this
> before the weekend because I won't be around to respond. So I plan on
> pushing this on Monday unless Stefan you want to do it earlier.

Thanks. I couldn't resist landing it. Inbound looks OK: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1665c708ebabf7b6e31c741cd4590f14e3e5beba
https://hg.mozilla.org/mozilla-central/rev/7df6fed09fb8
https://hg.mozilla.org/mozilla-central/rev/1665c708ebab
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Depends on: 1272966
Blocks: 1491766
You need to log in before you can comment on or make changes to this bug.