bugzilla.mozilla.org will be intermittently unavailable on Saturday, March 24th, from 16:00 until 20:00 UTC.

Remove close button from addon install notification

VERIFIED FIXED in Firefox 55



Add-ons Manager
2 years ago
11 months ago


(Reporter: cpeterson, Assigned: aswan)


(Blocks: 1 bug)

Dependency tree / graph

Firefox Tracking Flags

(firefox45 wontfix, firefox46 wontfix, firefox47 wontfix, firefox48 wontfix, firefox-esr38 unaffected, firefox52 wontfix, firefox53 wontfix, firefox54 fix-optional, firefox55 verified)


(Whiteboard: [door hanger] triaged)

MozReview Requests


Submitter Diff Changes Open Issues Last Updated
Error loading review requests:


(1 attachment)



2 years ago
1. Load https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/
2. Click the page's "Add to Firefox" button.
3. If necessary, click the "Allow" button on the "Firefox prevented this site from asking you to install software on your computer." door hanger.
4. When the "This site would like to install an add-on" door hanger appears, click the page to dismiss the the door hanger WITHOUT clicking the door hanger's "Install" or "Cancel" buttons.
5. Click the page's "Add to Firefox" button again.

The "This site would like to install an add-on" door hanger will open briefly and then disappear. You can no longer install the add-on from this page. If you open the Add-ons Manager, you will see two placeholder entries (with status "Downloaded") for the add-on that was not installed.

This bug might be a dupe of bug 622960 or bug 1207350.

Comment 1

2 years ago
Agree this is an issue and a pain point - but a very big bug of overall door-hanger issue.  We will have to take these all at once.

we've fixed as many simply as we could - and are putting these under main bug for future. bug 1171636
Blocks: 1171636
Priority: -- → P4
Whiteboard: [door hanger] triaged


2 years ago
Priority: P4 → P3
Comment hidden (mozreview-request)

Comment 3

a year ago
I will be the first to agree that this is not intuitive, but in the original STR, there should still be a puzzle piece icon on the left side of the location bar, clicking on that will bring back the Cancel/Install popup and let you proceed.
However, due to a bunch of work in the elm project, we can now make this even better without much trouble.  That popup is now persistent so stray clicks won't cause it to be dismissed.  There's still a close button on the popup but I think we should get rid of it, which the attached patch does.  Markus, does this seem okay?

Comment 4

a year ago
eh Markus is refusing needinfo requests, I'll try to collar him in Hawaii, I think this should be uncontroversial.


a year ago
Duplicate of this bug: 1207350


a year ago
Assignee: nobody → aswan

Comment 6

a year ago
Whoops, I sat on this patch for a long time and forgot about it.  I don't think any tests are needed for this...
Comment hidden (mozreview-request)


a year ago
Attachment #8816240 - Flags: review?(florian)

Comment 8

a year ago
Comment on attachment 8816240 [details]
Bug 1256221 Remove close button from addon install popup


No reason to show the 'x' button here. Could you please rephrase the bug summary to make this less confusing?
Attachment #8816240 - Flags: review?(florian) → review+


a year ago
Summary: Can't install add-on after dismissing "site would like to install an add-on" door hanger by clicking page → Remove close button from addon install notification

Comment 9

a year ago
Pushed by aswan@mozilla.com:
Remove close button from addon install popup r=florian

Comment 10

a year ago
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Verified as fixed on Firefox 55.0a1 (2017-03-17) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac Os X 10.12.1. “X” button is no longer displayed in installation pop-ups: https://www.screencast.com/t/XzimtWmYDJr .
status-firefox52: --- → affected
status-firefox53: --- → affected
status-firefox54: --- → affected
status-firefox55: fixed → verified
Is this worth uplifting to 54?  It's been there forever, otoh it's a one liner.
status-firefox45: affected → wontfix
status-firefox46: affected → wontfix
status-firefox47: affected → wontfix
status-firefox48: affected → wontfix
status-firefox52: affected → wontfix
status-firefox53: affected → wontfix
status-firefox54: affected → fix-optional

Comment 13

11 months ago
(In reply to Julien Cristau [:jcristau] from comment #12)
> Is this worth uplifting to 54?  It's been there forever, otoh it's a one
> liner.

I'm inclined to just let it ride the trains unless somebody else feels very strongly.

Comment 14

11 months ago
We probably don't need to uplift to 54. This bug is less likely to happen in 54 than earlier versions because the door hanger has been redesigned. Clicking the page does not accidentally dismiss the door hanger and leave it in a bad state. The user can still enter the bad state by clicking the door hanger's X button, but I expect that few users will do that because the new door hanger design's Install and Cancel buttons are now very prominent.
You need to log in before you can comment on or make changes to this bug.