Closed
Bug 1256535
Opened 8 years ago
Closed 8 years ago
intl\icu\source\common\unicode/uset.h(322): warning C4577: 'noexcept' used with no exception handling mode specified; termination on exception is not guaranteed. Specify /EHsc
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(2 files)
This compilation warning turns into an error when compiling Key.cpp on Visual Studio 2015 Update 1 in automation.
Assignee | ||
Comment 1•8 years ago
|
||
As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. That being said, the warning occurs in 3rd party ICU code. So I'm not sure what my options are for fixing this. Review commit: https://reviewboard.mozilla.org/r/39967/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39967/
Attachment #8730518 -
Flags: review?(birunthan)
Comment 2•8 years ago
|
||
Comment on attachment 8730518 [details] MozReview Request: Bug 1256535 - Disable C4577 to unblock compilation on VS2015; r?poiru https://reviewboard.mozilla.org/r/39967/#review36513 Please remove mention of ICU from the commit message. The Bugzilla summary is also incorrect. (FWIW, the same comment also applies to bug 1256509, but I missed it earlier.)
Attachment #8730518 -
Flags: review?(birunthan) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8730518 [details] MozReview Request: Bug 1256535 - Disable C4577 to unblock compilation on VS2015; r?poiru Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39967/diff/1-2/
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gps
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•8 years ago
|
||
https://reviewboard.mozilla.org/r/39967/#review36513 I've been copying Visual Studio output to use for bug summaries. Surprisingly, warnings from included header files print the header with the warning but not the source file. When building with -j8 or higher, it can actually be quite difficult at times to identify which source file failed because of this. *sigh*.
Assignee | ||
Comment 6•8 years ago
|
||
The previous disabling of this warning on just Key.cpp was not sufficient because another file from the unified sources list appears to include the header exhibiting the warning. Review commit: https://reviewboard.mozilla.org/r/39979/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39979/
Attachment #8730529 -
Flags: review?(birunthan)
Comment 7•8 years ago
|
||
Comment on attachment 8730529 [details] MozReview Request: Bug 1256535 - Disable C4577 to unblock compilation on VS2015; r?poiru https://reviewboard.mozilla.org/r/39979/#review36521
Attachment #8730529 -
Flags: review?(birunthan) → review+
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b56407b86b13 https://hg.mozilla.org/mozilla-central/rev/0ed826f3d277
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•