1257019 - Add move construction to js::Mutex<T>

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Add move construction to js::Mutex<T>

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cce163353576

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8730982 [details] [diff] [review]
Add move construction to js::Mutex<T>

Review of attachment 8730982 [details] [diff] [review]:
-----------------------------------------------------------------

Please add tests covering the new functionality to jsapi-tests/testThreadingMutex.cpp.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Add move construction to js::Mutex<T>

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Add move construction to js::Mutex<T>

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Now with tests and rebase!

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f48510ffeb4a

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1364b664788a

Comment 8

[Phil Ringnalda (:philor)]

No, that wasn't your try push, that was four meaningless jobs which stayed tier-1 while RyanVM accidentally made everything that matters tier-3 for a while. Your try push would be https://treeherder.mozilla.org/#/jobs?repo=try&revision=f48510ffeb4a&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=18237582

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b0e2c28119d8

Comment 9

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Add move construction to js::Mutex<T>

Ok, let's try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe91dc28bcb0

Comment 10

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Much better!

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5e77c8d64c9

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d5e77c8d64c9