1257040 - icu\source\common\unicode/ucasemap.h(93): warning C4577: 'noexcept' used with no exception handling mode specified; termination on exception is not guaranteed. Specify /EHsc

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gregory Szorc [:gps]]

This is similar to bug 1256509 but for code in js/src.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1257040 - Disable C4577 to unblock compilation on VS2015; r?jorendorff

As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists of fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary. That being said, the warnings this patch masks are
in an included ICU header, which is a 3rd party project. So our hands
appear tied.

Review commit: https://reviewboard.mozilla.org/r/40309/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40309/

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 8731011 [details]
MozReview Request: Bug 1257040 - Disable C4577 to unblock compilation on VS2015; r?jorendorff

https://reviewboard.mozilla.org/r/40309/#review36935

This warning is irrelevant to us anyway.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3d0a6754976

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3d0a6754976