Closed Bug 1257204 Opened 6 years ago Closed 5 years ago

Make login manager 'Delete' localization comment more generic for delete action and button in list/detail view

Categories

(Firefox for iOS :: General, defect)

Other
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: sleroux, Assigned: flod)

References

Details

Since we already were string frozen for 3.0, to have the 'Delete' string localized I used the string we use for the login detail page [1]. The only issue is the localization comment refers to the detail screen. The comment should be more generic to allow it to be used in both the login list screen and detail screen.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1242025
Adding Bug 1256395 as parent even though we would do this for 4.0 just so we don't lose track of it.
Blocks: 1256395
Summary: Make login manager 'Delete' localization comment more generic fir delete action and button in list/detail view → Make login manager 'Delete' localization comment more generic for delete action and button in list/detail view
Hey Stefan,

Do you have any suggestions over making this comment more generic? The current comment looks like:

"Button in login detail screen that deletes the current login"

Now that we use delete in both list of logins and detail page this doesn't make sense. Would something like this work:

"Title for delete action when removing a login"

Action indicating that it can be both the button in the detail page and also the action button in the top right in the list view.
Flags: needinfo?(splewako)
When I read "Title for action" I think about window/screen/dialog title not a button label, I think "Delete [action] button [label]" would be more understandable.

Making a comment more or less specific doesn't enable different string translations (only one per table/file with current ids) and only somewhat affects qa. I don't know also if changed comments are counted against the "string freeze".

I would use more specific comments, like "Delete button label in login detail screen" and "Delete button label in logins list editing screen" in our case.
Flags: needinfo?(splewako)
Blocks: 1264283
Blocks: 1277326
Assignee: nobody → francesco.lodolo
Comments updated as part of 
https://github.com/mozilla/firefox-ios/commit/99ea79a58b307a641a2cde0d94cf6d226ce8212f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.