1257320 - icu\source\common\unicode/ucasemap.h(93): warning C4577: 'noexcept' used with no exception handling mode specified; termination on exception is not guaranteed. Specify /EHsc from unified dns

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect)

Description

[Gregory Szorc [:gps]]

This is similar to bug 1257040 and bug 1256513 and a few other bugs. We're unmasking this warning and it gets turned into an error when building with Visual Studio 2015 Update 1 in automation.

This warning has been masked in a number of moz.build files. I'll file a follow-up to deal with it more robustly.

Comment 1

[Gregory Szorc [:gps]]

I did not mean bug 1256513. Look at the blockers for bug 1124033 for similar bug summaries as this one.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1257320 - Disable C4577 to unblock compilation on VS2015; r?mayhemer

As part of unblocking building with VS2015u1 in automation, I'm mass
disabling compiler warnings that are turned into errors. This is not
the preferred mechanism to fix compilation warnings. So hopefully
this patch never lands because someone insists of fixing the underlying
problem instead. But if it does land, hopefully the workaround is
only temporary. That being said, the warnings this patch masks are
in an included ICU header, which is a 3rd party project. So our hands
appear tied.

Review commit: https://reviewboard.mozilla.org/r/40569/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40569/

Comment 3

[Honza Bambas (:mayhemer)]

Same here as in bug 1256473.

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 8731416 [details]
MozReview Request: Bug 1257320 - Disable C4577 to unblock compilation on VS2015; r?mayhemer

https://reviewboard.mozilla.org/r/40569/#review37561

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6b2fc1bbac7

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b6b2fc1bbac7