1258071 - FeedConverter throws raw nsresults instead of exceptions (error from ContentLinkHandler.jsm on a document with <link rel="foo" href="feed:javascript:1"> fetching link.href property), should be using Components.Exception

Status: RESOLVED WONTFIX

(Firefox Graveyard :: RSS Discovery and Preview, defect, P3)

Description

[Jesse Ruderman]

Attachment: testcase

JavaScript error: resource://app/modules/ContentLinkHandler.jsm, line 41: uncaught exception: 2152398858

Comment 1

[:Gijs (he/him)]

It'd probably be worth having eslinting for this pattern. Mossop, is this something that you can throw on the eslint pile of work that you seem to be doing? :-)

Comment 2

[:Gijs (he/him)]

So to be clear, the real issue here are things like:

https://dxr.mozilla.org/mozilla-central/rev/55d557f4d73ee58664bdf2fa85aaab555224722e/browser/components/feeds/FeedConverter.js#509

Comment 3

[Dave Townsend [:mossop]]

(In reply to :Gijs Kruitbosch from comment #1)
> It'd probably be worth having eslinting for this pattern. Mossop, is this
> something that you can throw on the eslint pile of work that you seem to be
> doing? :-)

Sorry, I haven't even had time to finish up bug 1257246, I don't have any time available for this right now.

Comment 4

[Boris Zbarsky [:bzbarsky]]

The patches from bug 1260511 will help a bit here in the sense that the raw number will get converted to an exception object.  But 2152398858 = 0x804b000a looks to me like NS_ERROR_MODULE_NETWORK, and in particular NS_ERROR_MALFORMED_URI (yeah, I know, linked from comment 2), which is not an exception that should ever happen on the web.  I think typically SYNTAX_ERR is used for cases like this.

Comment 5

[Marco Bonardo [:mak]]

The feed preview code has been removed by bug 1477669.