1258523 - crash in java.lang.NullPointerException: at org.mozilla.gecko.toolbar.ToolbarDisplayLayout.updateFromTab(ToolbarDisplayLayout.java) in Firefox 47

Status: RESOLVED DUPLICATE of bug 1255767

(Firefox for Android Graveyard :: General, defect)

Description

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

+++ This bug was initially created as a clone of Bug #964861 +++

This bug was filed from the Socorro interface and is 
report bp-c31482de-7959-44ec-a98b-a75b82140126.
=============================================================

java.lang.NullPointerException
	at org.mozilla.gecko.toolbar.ToolbarDisplayLayout.updateFromTab(ToolbarDisplayLayout.java:267)
	at org.mozilla.gecko.toolbar.BrowserToolbar.onTabChanged(BrowserToolbar.java:531)
	at org.mozilla.gecko.Tabs$5.run(Tabs.java:595)

This crash signature is associated with top 3rd spot on Fennec Aurora 47 stability.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]:

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

This looks a lot like bug 1255767. I'll investigate.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

The stack traces are not really helpful (it's not fully shown the actual line of the NullPointerException):

> java.lang.NullPointerException
>	at org.mozilla.gecko.toolbar.ToolbarDisplayLayout.updateFromTab(ToolbarDisplayLayout.java:213)

Code:
http://hg.mozilla.org/releases/mozilla-aurora/file/tip/mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarDisplayLayout.java#l213

I assume this is bug 1255767 but with a slightly different stack trace (older Android version). 

The crashes here are on devices with API 16-19. The crashes in bug 1255767 are on devices with API 21-23. Additionally both crashes are only on Aurora right now. I requested uplift for the patch in bug 1255767 so I expect this to go away too.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for Fx 47 as it's a top crash.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Yep, build 2016-03-23 is the last one with crashes.

Comment 6

[:Margaret Leibovic]

The dupe fix was uplifted to 47, so this should be fixed as well.