1259251 - Redesign SiteTableViewController to the new mocks

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Bryan Munar (:bkmunar)]

Attachment: panelHistory.png

Comment 1

[Bryan Munar (:bkmunar)]

Attachment: PR

whoever gets to it first!

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8734177 [details] [review]
PR

Can you put more information in the bug or PR? I'm not really even sure what this bug is about, or what I should be looking for.

One thing I do notice is that all of the history cells look broken with this PR. Compare the margins, fonts, etc. of your screenshot with master.

Comment 3

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 4

[Bryan Munar (:bkmunar)]

Attachment: Screen Shot 2016-03-30 at 1.08.51 PM.png

comparison between mock and simulator

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8736927 [details] [review]
PR

I think this is on the right track, but it's pretty gnarly to create an individual lazy variable for each letter (which also wouldn't scale to other languages). Let's simplify this by making a dictionary that caches character -> UIImage pairs.

Comment 7

[Stephan Leroux [:sleroux]]

Comment on attachment 8736927 [details] [review]
PR

Left feedback on PR.

Comment 8

[Brian Nicholson (:bnicholson)]

Comment on attachment 8736927 [details] [review]
PR

Image caching looks good, but some questions/comments about layout.

Comment 9

[Brian Nicholson (:bnicholson)]

Comment on attachment 8736927 [details] [review]
PR

Still a bit more complex than I was hoping it would be, but I guess the rules for different borders and margins are non-trivial. Hopefully this complexity can go away once we update Remote Tabs to be like the rest of the panels.

Comment 10

[Bryan Munar (:bkmunar)]

Comment on attachment 8736927 [details] [review]
PR

oneee lasttt time~