1260418 - Horizontal line separator in new folder view switcher too short

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Jorg K (CEST = GMT+2)]

See bug 700976 comment 183 and attachment 8735836 [details]

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1260418.patch

This fixes the separator width on Windows. OS X and Linux are not affected.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8735984 [details] [diff] [review]
1260418.patch

Review of attachment 8735984 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK, but please fix the typo.

::: mail/base/content/mailWindowOverlay.xul
@@ +3352,5 @@
>                  crop="center"
>                  flex="1"
>                  label="&folderModeSelector.label;"
>                  oncommand="gFolderTreeView.mode = this.value;">
> +        <menupopup id="folderpane-mode-selector-poup"

No "poup" for me, please ;-)

::: mail/themes/windows/mail/primaryToolbar.css
@@ +187,5 @@
>  #folderPane-toolbar > :-moz-any(*) + :-moz-any(*) {
>    margin-inline-start: 2px;
>  }
>  
> +#folderpane-mode-selector-poup > menuseparator {

Ditto.

Comment 3

[:aceman]

Why is it needed to special-case this menulist? Can't the "shifted separator" style be automatically attached to menulists that actually have icons?

Comment 4

[Richard Marti (:Paenglab)]

http://hg.mozilla.org/comm-central/rev/5e7d42e21dc2

Comment 5

[Richard Marti (:Paenglab)]

Such menulists are not used in FX and the -moz-appearance: menuseparator; has always this margin at the left.

Comment 6

[:aceman]

There is also e.g. the id="viewPicker" menulist that has no icons (at least on Win XP). Could we make a class for these items and attach the style to it, not listing/adding all IDs as they are created? In a followup bug :)