Closed Bug 1260418 Opened 4 years ago Closed 4 years ago

Horizontal line separator in new folder view switcher too short

Categories

(Thunderbird :: Folder and Message Lists, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 48.0

People

(Reporter: jorgk-bmo, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Attached patch 1260418.patchSplinter Review
This fixes the separator width on Windows. OS X and Linux are not affected.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8735984 - Flags: review?(mozilla)
Comment on attachment 8735984 [details] [diff] [review]
1260418.patch

Review of attachment 8735984 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK, but please fix the typo.

::: mail/base/content/mailWindowOverlay.xul
@@ +3352,5 @@
>                  crop="center"
>                  flex="1"
>                  label="&folderModeSelector.label;"
>                  oncommand="gFolderTreeView.mode = this.value;">
> +        <menupopup id="folderpane-mode-selector-poup"

No "poup" for me, please ;-)

::: mail/themes/windows/mail/primaryToolbar.css
@@ +187,5 @@
>  #folderPane-toolbar > :-moz-any(*) + :-moz-any(*) {
>    margin-inline-start: 2px;
>  }
>  
> +#folderpane-mode-selector-poup > menuseparator {

Ditto.
Attachment #8735984 - Flags: review?(mozilla) → review+
Why is it needed to special-case this menulist? Can't the "shifted separator" style be automatically attached to menulists that actually have icons?
http://hg.mozilla.org/comm-central/rev/5e7d42e21dc2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
Such menulists are not used in FX and the -moz-appearance: menuseparator; has always this margin at the left.
There is also e.g. the id="viewPicker" menulist that has no icons (at least on Win XP). Could we make a class for these items and attach the style to it, not listing/adding all IDs as they are created? In a followup bug :)
Depends on: 1260697
You need to log in before you can comment on or make changes to this bug.