Closed Bug 1260697 Opened 4 years ago Closed 4 years ago

Use a class for menulist popups without icons

Categories

(Thunderbird :: Theme, defect)

All
Windows
defect
Not set

Tracking

(thunderbird46 wontfix, thunderbird47 fixed, thunderbird48 fixed, thunderbird_esr4546+ fixed)

RESOLVED FIXED
Thunderbird 48.0
Tracking Status
thunderbird46 --- wontfix
thunderbird47 --- fixed
thunderbird48 --- fixed
thunderbird_esr45 46+ fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

From bug 1260418 comment 6:
> There is also e.g. the id="viewPicker" menulist that has no icons (at least
> on Win XP). Could we make a class for these items and attach the style to
> it, not listing/adding all IDs as they are created? In a followup bug :)
You're okay with this class name?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8736287 - Flags: review?(acelists)
Comment on attachment 8736287 [details] [diff] [review]
Add a class for menulist no icon popups

Review of attachment 8736287 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, perfect, thanks! I can't test it on Windows, but I trust that it works.
Attachment #8736287 - Flags: review?(acelists) → review+
http://hg.mozilla.org/comm-central/rev/ddcbed3a77c0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 48.0
Comment on attachment 8736287 [details] [diff] [review]
Add a class for menulist no icon popups

[Approval Request Comment]
User impact if declined: only visual bug
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low added a class
Attachment #8736287 - Flags: approval-comm-esr45?
Attachment #8736287 - Flags: approval-comm-beta?
Attachment #8736287 - Flags: approval-comm-aurora?
Blocks: 1265170
Attachment #8736287 - Flags: approval-comm-aurora? → approval-comm-aurora+
Aurora (TB 47):
https://hg.mozilla.org/releases/comm-aurora/rev/35db6d2598f6

The patch landed is different to the C-C version.
These hunks couldn't be applied since they refer to stuff from bug 700976:
mailWindowOverlay.xul.rej
         <menupopup id="folderpane-mode-selector-popup"
+                   class="noIconPopup"
                    onpopupshowing="gFolderTreeView._initFolderModeSelector();"/>

primaryToolbar.css.rej
-#folderpane-mode-selector-popup > menuseparator {
-  -moz-appearance: none;
-  margin-top: 3px;
-  margin-bottom: 3px;
-  padding: 0;
-  border-top-color: #d7d7d7;
-}
Attachment #8736287 - Flags: approval-comm-esr45? → approval-comm-esr45+
Attachment #8736287 - Flags: approval-comm-beta? → approval-comm-beta-
Blocks: 1278489
You need to log in before you can comment on or make changes to this bug.