1260697 - Use a class for menulist popups without icons

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

From bug 1260418 comment 6:
> There is also e.g. the id="viewPicker" menulist that has no icons (at least
> on Win XP). Could we make a class for these items and attach the style to
> it, not listing/adding all IDs as they are created? In a followup bug :)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Add a class for menulist no icon popups

You're okay with this class name?

Comment 2

[:aceman]

Comment on attachment 8736287 [details] [diff] [review]
Add a class for menulist no icon popups

Review of attachment 8736287 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, perfect, thanks! I can't test it on Windows, but I trust that it works.

Comment 3

[Richard Marti (:Paenglab)]

http://hg.mozilla.org/comm-central/rev/ddcbed3a77c0

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 8736287 [details] [diff] [review]
Add a class for menulist no icon popups

[Approval Request Comment]
User impact if declined: only visual bug
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low added a class

Comment 5

[Jorg K (CEST = GMT+2)]

Aurora (TB 47):
https://hg.mozilla.org/releases/comm-aurora/rev/35db6d2598f6

The patch landed is different to the C-C version.
These hunks couldn't be applied since they refer to stuff from bug 700976:
mailWindowOverlay.xul.rej
         <menupopup id="folderpane-mode-selector-popup"
+                   class="noIconPopup"
                    onpopupshowing="gFolderTreeView._initFolderModeSelector();"/>

primaryToolbar.css.rej
-#folderpane-mode-selector-popup > menuseparator {
-  -moz-appearance: none;
-  margin-top: 3px;
-  margin-bottom: 3px;
-  padding: 0;
-  border-top-color: #d7d7d7;
-}

Comment 6

[Kent James (:rkent)]

http://hg.mozilla.org/releases/comm-esr45/rev/5fbaf665531d