126059 - disable menu stuff for images

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P1)

Description

[Henrik Gemal]

we might as well disable the following stuff under Edit for images:
Text Zoom
Use Stylesheets
Charater Coding

and under Search
everything...

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

you wouldn't want to disable "Search the Web".

anyway, taking

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

this should fix it.

btw, you need not cc me on bugs that are assigned to me :)

Comment 3

[timeless]

Comment on attachment 69993 [details] [diff] [review]
patch

noImage should be isImage and i'm opposed to disabling view-source even though
it's currently broken

Comment 4

[Alec Flett]

why did you remove the references to the translateMenu?

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

alecf: because I'm now using the broadcaster to change the disabled state of the
translate menu

alec or blake, could one of you super-review?

Comment 6

[sairuh (rarely reading bugmail)]

cc'ing marlon in case he might have opinions here...

Comment 7

[marlon bishop]

don't disable anything underneath "search the web" either. otherwise disabling
those other things makes sense.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

uh, there _is_ nothing underneath search the web...

Comment 9

[marlon bishop]

uh, there _is_ in commercial...

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

ah sure, forgot about that. such entries will not be disabled because of my patch.

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: new patch

fixes timeless' comments
this patch should also fix the problem smaug reported in bug 122144.

Comment 12

[Alec Flett]

Comment on attachment 70315 [details] [diff] [review]
new patch

sr=alecf

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in, just in time for 0.9.9 :)

Comment 14

[Henrik Gemal]

v 20020221