1261103 - [gtk3] Add new engine panel from search bar has the wrong styling

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Bogdan Maris, Desktop Test Engineering [OOO until 14th April]]]

[Affected versions]:
- Firefox 46 beta 6
- latest Aurora 47.0a2
- latest Nightly 48.0a1

[Affected platforms]:
- Ubuntu 12.04 32-bit

[Steps to reproduce]:
1. Open Firefox
2. Visit a website that has a search engine (eg. https://bugzilla.mozilla.org/)
3. Click on Magnifying glass from Search bar.

[Expected result]:
- Add new engine field is colored differently from the other items from panel.

[Actual result]:
- Add new engine field has the same background color as the entire panel.

[Regression range]:
- This is not a regression since the issue is reproducible only on gtk3 builds. 

[Additional notes]:
- Screenshot added in URL field.
- This is not reproducible on GTK2 builds.

Comment 1

[:Gijs (he/him)]

Can you retest on a build that includes bug 1238866 ?

Comment 2

[Bogdan Maris, Desktop Test Engineering [OOO until 14th April]]]

Same behavior with Firefox 46 beta 7 build 2 and latest Nightly.

Comment 3

[:Gijs (he/him)]

Wait, that screenshot (in the URL field) is just the desired result, I think? Florian?

Comment 4

[Florian Quèze [:florian]]

(In reply to :Gijs Kruitbosch from comment #3)
> Wait, that screenshot (in the URL field) is just the desired result, I
> think? Florian?

Right... which makes me wonder what "This is not reproducible on GTK2 builds." in comment 0 means. Bogdan, can you clarify?

Comment 5

[Bogdan Maris, Desktop Test Engineering [OOO until 14th April]]]

Attachment: Screenshot showing the issue

(In reply to Florian Quèze [:florian] [:flo] from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > Wait, that screenshot (in the URL field) is just the desired result, I
> > think? Florian?
> 
> Right... which makes me wonder what "This is not reproducible on GTK2
> builds." in comment 0 means. Bogdan, can you clarify?

Here is a screenshot of the differences between GTK2 and GTK3.

Well, if the right layout is the one from GTK3 build, than this bug will become invalid.

Comment 6

[:Gijs (he/him)]

(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #5)
> Created attachment 8738047 [details]
> Screenshot showing the issue
> 
> (In reply to Florian Quèze [:florian] [:flo] from comment #4)
> > (In reply to :Gijs Kruitbosch from comment #3)
> > > Wait, that screenshot (in the URL field) is just the desired result, I
> > > think? Florian?
> > 
> > Right... which makes me wonder what "This is not reproducible on GTK2
> > builds." in comment 0 means. Bogdan, can you clarify?
> 
> Here is a screenshot of the differences between GTK2 and GTK3.
> 
> Well, if the right layout is the one from GTK3 build, than this bug will
> become invalid.

OK, thanks for checking!