Closed Bug 1261687 Opened 4 years ago Closed 4 years ago

Detached devtools window title changes when selecting another frame

Categories

(DevTools :: General, defect)

48 Branch
defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

Regression from Bug 1260359.

STRs:
- open https://developer.mozilla.org/en/docs/Web/HTML/Element/iframe
- open devtools in detached window
- in the devtools frames list, switch to https://mdn-samples.mozilla.org/snippets/html/iframe-simple-contents.html

AR: Title of the detached devtools window becomes "Inspector - iframe Example"
ER: Title should remain "Inspector - <iframe> - HTML | MDN"

A "fake" navigation event is actually triggered when selecting another top-level document in the devtools frames list.
In Bug 1258740, there is an ongoing discussion to update the title when selecting another frame. In the meantime, we should fix the regression.
Assignee: nobody → jdescottes
Blocks: 1258740
Status: NEW → ASSIGNED
Keywords: regression
See Also: → 1260359
Check the "isFrameSwitching" property of the tabNavigated event before
updating the devtools title. If frameSwitching is true, the event is a
fake event generated by the webbrowser actor when switching the frame
context in the devtools.

Added another mochitest to verify this.

Review commit: https://reviewboard.mozilla.org/r/44037/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44037/
Attachment #8737615 - Flags: review?(jryans)
Comment on attachment 8737615 [details]
MozReview Request: Bug 1261687 - Don't update devtools title if tabNavigated.isFrameSwitching;r=jryans

https://reviewboard.mozilla.org/r/44037/#review40689

Great, thanks for fixing this!
Attachment #8737615 - Flags: review?(jryans) → review+
Thanks for the review, and sorry for missing this in the initial bug!

Will push to try and land if try is green.
https://hg.mozilla.org/mozilla-central/rev/d82b170cd516
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.