1261687 - Detached devtools window title changes when selecting another frame

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Julian Descottes [:jdescottes]]

Regression from Bug 1260359.

STRs:
- open https://developer.mozilla.org/en/docs/Web/HTML/Element/iframe
- open devtools in detached window
- in the devtools frames list, switch to https://mdn-samples.mozilla.org/snippets/html/iframe-simple-contents.html

AR: Title of the detached devtools window becomes "Inspector - iframe Example"
ER: Title should remain "Inspector - <iframe> - HTML | MDN"

A "fake" navigation event is actually triggered when selecting another top-level document in the devtools frames list.

Comment 1

[Julian Descottes [:jdescottes]]

In Bug 1258740, there is an ongoing discussion to update the title when selecting another frame. In the meantime, we should fix the regression.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: MozReview Request: Bug 1261687 - Don't update devtools title if tabNavigated.isFrameSwitching;r=jryans

Check the "isFrameSwitching" property of the tabNavigated event before
updating the devtools title. If frameSwitching is true, the event is a
fake event generated by the webbrowser actor when switching the frame
context in the devtools.

Added another mochitest to verify this.

Review commit: https://reviewboard.mozilla.org/r/44037/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44037/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8737615 [details]
MozReview Request: Bug 1261687 - Don't update devtools title if tabNavigated.isFrameSwitching;r=jryans

https://reviewboard.mozilla.org/r/44037/#review40689

Great, thanks for fixing this!

Comment 4

[Julian Descottes [:jdescottes]]

Thanks for the review, and sorry for missing this in the initial bug!

Will push to try and land if try is green.

Comment 5

[Julian Descottes [:jdescottes]]

Try is green : https://treeherder.mozilla.org/#/jobs?repo=try&revision=4709e3b78d65

Landing.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d82b170cd516

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d82b170cd516