[e10s] Detached devtools window title is not updated when navigating

VERIFIED FIXED in Firefox 48

Status

()

Firefox
Developer Tools
P2
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

47 Branch
Firefox 48
Points:
---

Firefox Tracking Flags

(e10s+, firefox45 unaffected, firefox46 affected, firefox47 affected, firefox48 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

STRs: 
- open https://developer.mozilla.org/en-US/
- open devtools as a detached window
- (here devtools window title should be "Inspector - Mozilla Developer Network")
- navigate to https://bugzilla.mozilla.org/

Expected:
- detached devtools window title should be "Inspector - Bugzilla Main Page"

Actual:
- detached devtools window title is still "Inspector - Mozilla Developer Network"
status-firefox45: --- → unaffected
status-firefox46: --- → affected
status-firefox47: --- → affected
status-firefox48: --- → affected
status-firefox46: affected → unaffected
status-firefox46: unaffected → affected
Actually related to e10s. 

The name getter in target.js is accessing this._tab.linkedBrowser.contentDocument which may not work when e10s is enabled.
tracking-e10s: --- → ?
Summary: Detached devtools window title is not updated when navigating → [e10s] Detached devtools window title is not updated when navigating
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: -- → P2
Created attachment 8735859 [details]
MozReview Request: Bug 1260359 - fix devtools detached toolbox title update in e10s;r=jryans

The devtools host window updates its title when its target navigates.
This was done using a contentDocument CPOW, and thus failing on e10s.

The url and title are now updated in TabTarget.form upon tab navigation.
Updated existing test to cover the case of pages with a title.

Review commit: https://reviewboard.mozilla.org/r/42989/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42989/
Attachment #8735859 - Flags: review?(jryans)
tracking-e10s: ? → +
Comment on attachment 8735859 [details]
MozReview Request: Bug 1260359 - fix devtools detached toolbox title update in e10s;r=jryans

https://reviewboard.mozilla.org/r/42989/#review39633

Looks good, thanks for working on it!

::: devtools/client/framework/target.js:476
(Diff revision 1)
> +      this._form.url = aPacket.url;
> +      this._form.title = aPacket.title;

It's a little strange to mutate the form here, since previously I thought of the form as data we received as a complete protocol packet...  but in the end this is probably okay.  We can always change if it becomes confusing.
Attachment #8735859 - Flags: review?(jryans) → review+
Comment on attachment 8735859 [details]
MozReview Request: Bug 1260359 - fix devtools detached toolbox title update in e10s;r=jryans

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/42989/diff/1-2/
Comment on attachment 8735859 [details]
MozReview Request: Bug 1260359 - fix devtools detached toolbox title update in e10s;r=jryans

Thanks for the review! I had another look at the fix based on your comment. I think we should avoid updating form here, as you said. 

It seems weird for me to have outdated information in this object, but it is definitely not the role of target.js to update this object.

Instead here I read the url & title from the form when receiving the payload, save them as properties on TabTarget directly, and update them when navigating.

Let me know if you prefer to go with this one.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6b152fb6072
Attachment #8735859 - Flags: review+ → review?(jryans)
Comment on attachment 8735859 [details]
MozReview Request: Bug 1260359 - fix devtools detached toolbox title update in e10s;r=jryans

https://reviewboard.mozilla.org/r/42989/#review39837

Cool, let's go with this one then.  Thanks!
Attachment #8735859 - Flags: review?(jryans) → review+

Updated

2 years ago
See Also: → bug 1258740

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/34fabc54b7a4
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48

Comment 10

2 years ago
Affected:   Win7_64, Nightly 48, 32bit, ID 20160320030409
Fixed on:   Win7_64, Nightly 48, 32bit, ID 20160401030216
Status: RESOLVED → VERIFIED
status-firefox48: fixed → verified
See Also: → bug 1261687
You need to log in before you can comment on or make changes to this bug.