1262073 - add regex for mozilla-release desktop ff name support in release-runner.py staging

Status: RESOLVED DUPLICATE of bug 1263976

(Release Engineering :: Release Automation: Other, defect)

Description

[Jordan Lund (:jlund)]

currently staging will only do beta http://hg.mozilla.org/build/tools/file/c8bed25d4e07/buildfarm/release/release-runner.py#l59

old-release-runner will need to be tweaked too: http://hg.mozilla.org/build/tools/file/old-release-runner/buildfarm/release/release-runner.py#l43

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: MozReview Request: Bug 1262073 - tweak old release runner to filter out mozilla-release as well. r=jlund

Review commit: https://reviewboard.mozilla.org/r/44355/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44355/

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8738142 [details]
MozReview Request: Bug 1262073 - tweak old release runner to filter out mozilla-release as well. r=jlund

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44355/diff/1-2/

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

@jlund:

Sorry I stepped on your toes here, but since I added the regex part there, I thought I could give you a hand:

the default branch:
* should catch all Firefox desktop beta, release and dot releases, but *not* the ESR

the oldrelease-runner branch:
* everything else except the firefox desktop beta, release and dot release

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 8738142 [details]
MozReview Request: Bug 1262073 - tweak old release runner to filter out mozilla-release as well. r=jlund

https://reviewboard.mozilla.org/r/44355/#review41067

::: buildfarm/release/release-runner.py:43
(Diff revision 2)
> -# handled separately within release promotion. Once migration from buildbot
> -# to promotion is completed for all types of releases, we will backout this
> -# filtering  - bug 1252333
> +# as they're handled separately within release promotion. Once migration to
> +# promotion is completed for all types of releases, we will backout this
> +# regex beta tracking bug is 1252333
> +# regex release tracking bug is 1262073
>  RELEASE_PATTERNS = [
> -    # all Firefox non-betas
> +    # all Firefox non(mozilla-beta or mozilla-release)

such a programmer. you even factor out a common negative value from within comments!

Comment 5

[Jordan Lund (:jlund)]

(In reply to Mihai Tabara [:mtabara] from comment #3)
> @jlund:
> 
> Sorry I stepped on your toes here, but since I added the regex part there, I
> thought I could give you a hand:
> 
> the default branch:
> * should catch all Firefox desktop beta, release and dot releases, but *not*
> the ESR
> 
> the oldrelease-runner branch:
> * everything else except the firefox desktop beta, release and dot release

yep. sounds about right.

I couldn't review the two patches individually because of limitations with mozreview across multiple branches against the same bug. niche case I guess.

mihai, I think we should remove the mozreview, split this into two patches and attach it to the bug so it is more obvious. The motivation there is because this will stop us from being able to do a dot release on prod ship-it (pre relpro env) and I think we are going to have one more dot release prior to 46.0 so we will need to be able to back this out.

thanks for the patches!

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Tweak relpro release runner to handle along betas, mozilla-release as well

Comment 7

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Tweak old release runner to filter out mozilla-release

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

jlund:

So per IRC/mtg my understanding is this:

0. didn't know how to remove the MozReview but instead marked it as obsolete

1. TIL

bm81: prod non-relpro
bm83: dev relpo
bm85: prod relpro

2. 
* once both patches are reviewed, I will import the changes from the <default> branch in the bm83 and we can start a dev release there to  see how that goes

3. Once we're past the potential dot release and we're clear to go for 46.0 we can push it to both branches

Sounds good?

Comment 9

[Jordan Lund (:jlund)]

(In reply to Mihai Tabara [:mtabara] from comment #8)
> jlund:
> 
> So per IRC/mtg my understanding is this:
> 
> 0. didn't know how to remove the MozReview but instead marked it as obsolete
> 
> 1. TIL
> 
> bm81: prod non-relpro
> bm83: dev relpo
> bm85: prod relpro
> 
> 2. 
> * once both patches are reviewed, I will import the changes from the
> <default> branch in the bm83 and we can start a dev release there to  see
> how that goes
> 
> 3. Once we're past the potential dot release and we're clear to go for 46.0
> we can push it to both branches
> 
> Sounds good?

yep. sorry about that. I forgot there was three nodes and that I suppose bm81 is not even aware of anything I do on ship-it-dev.

Comment 10

[Jordan Lund (:jlund)]

Comment on attachment 8738226 [details] [diff] [review]
Tweak relpro release runner to handle along betas, mozilla-release as well

Review of attachment 8738226 [details] [diff] [review]:
-----------------------------------------------------------------

carrying mozreview r+ forward