1262455 - Web page title / content information isn't shown in the standalone infobar when two people are in the room

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

The title of the web page / context information isn't show in the standalone infobar when two people are in the room.

You get something until the link generator enters the room, and then it is blank.

Sevaan, can you confirm how this is meant to work please? (I think its update the title of the page being shared as we get the new tile information i.e. on domain name change?)

Comment 1

[Sevaan Franks [:sevaan]]

Are you referring to the title bar in the conversation window?

Comment 2

[Mark Banner (:standard8)]

(In reply to Sevaan Franks [:sevaan] from comment #1)
> Are you referring to the title bar in the conversation window?

No, the standalone web page - where the ToS is displayed, but then changes to the context title when you join the room.

Comment 3

[Sevaan Franks [:sevaan]]

Ah, well it should work however we have the Conversation Window title currently work.

I believe it updated for each domain, unless the user ends the session, and then it updates with the last page the user was on. Also, to prevent flooding, the room title should update after a user has spent X seconds on the page. That way we prevent the title updating if someone is flipping through a lot of tabs.

I feel that we should have a "Welcome to [Room Name]" at the top of the chat though. Why/when did it get removed?

Pau, do you know?

Comment 4

[Manuel Casas Barrado [:mancas]]

What we have at the top of the chat is "Welcome to Firefox Hello" and as you said, the tile change in the standalone every time the owner spent a few seconds on a different page but when the clicker leaves the room, the ToS is displayed again.

Comment 5

[Pau Masiá [:Pau]]

You're right Sevaan. I wasn't aware it got removed. I would still go with what we had planned and move forward for future versions.
So, to sum up:

- When users don't set a name for the room = "Welcome to Firefox Hello"
- When users do set a name for the room = "Welcome to [Room Name]"

Comment 6

[GitHub Autolander Bot]

Attachment: [loop] mancas:bug1262455 > mozilla:master

Comment 7

[Mark Banner (:standard8)]

Attachment: Screen shot of issues (link clicker only in room -> both in room)

I probably should have included this to be clear in the beginning this is about the infobar, not the text chat area. 

This never says "Welcome to ...." - it shows the ToS before the room is joined. Then when the link clicker is the only one in the room, it gives the room context information.

Finally, when the link generator joins, the room context information disappears.

That's the weird bit, and I think the intention was to display the latest room context there.

The "Welcome to ..." isn't part of this bug, that's bug 1262441.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8739368 [details] [review]
[loop] mancas:bug1262455 > mozilla:master

r- as this is addressing the wrong issue.

Comment 9

[Sevaan Franks [:sevaan]]

Thanks Mark. 

When a guest first joins the room, display TOS.
After clicking the Join button, if the guest is alone display "Welcome to [Room Name]"
If guest is not alone, or the room owner joins, then display page title of whatever is being shared/looked at.

Comment 10

[Manuel Casas Barrado [:mancas]]

New patch: The info bar display "Welcome to [Room name]" if the room has a name or "Welcome to Firefox Hello" if not.

Comment 11

[Fernando Campo (:fcampo)]

Comment on attachment 8739368 [details] [review]
[loop] mancas:bug1262455 > mozilla:master

small nit on github, and needs some fixes on the tests.
Otherwise than that code is ok, tested on nightly.

r+ after fixes.

Comment 12

[Mark Banner (:standard8)]

https://github.com/mozilla/loop/commit/78e4e52bc17daa7a946c0870793f680f87f754b5