Allow resizing the area selected by measuring tool via keyboard
Categories
(DevTools :: Inspector, enhancement, P3)
Tracking
(firefox117 fixed)
Tracking | Status | |
---|---|---|
firefox117 | --- | fixed |
People
(Reporter: sebo, Assigned: vinny.diehl)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, good-first-bug, Whiteboard: [btpp-backlog])
Attachments
(1 file, 10 obsolete files)
Comment 1•9 years ago
|
||
Updated•8 years ago
|
Comment 2•8 years ago
|
||
Reporter | ||
Comment 3•8 years ago
|
||
Reporter | ||
Updated•8 years ago
|
Comment 4•7 years ago
|
||
Updated•7 years ago
|
Reporter | ||
Comment 5•7 years ago
|
||
Comment 6•7 years ago
|
||
Comment 9•7 years ago
|
||
Comment 10•7 years ago
|
||
Comment 11•7 years ago
|
||
Comment 12•7 years ago
|
||
Comment 13•7 years ago
|
||
Comment 14•7 years ago
|
||
Comment 15•7 years ago
|
||
Comment 16•7 years ago
|
||
Comment 17•7 years ago
|
||
Comment 18•7 years ago
|
||
Comment 19•7 years ago
|
||
Updated•7 years ago
|
Comment 20•7 years ago
|
||
Updated•7 years ago
|
Comment 21•6 years ago
|
||
Resetting the assignee field so others can pick this bug up, since it has been close to 1 year. Feel free to claim it again if you did intend to work on it after all.
Most of the work was done already, and not much has changed (if anything) in the measuring tool, so this patch should still apply without much problems.
Comment 22•6 years ago
|
||
(In reply to Patrick Brosset <:pbro> from comment #21)
Resetting the assignee field so others can pick this bug up, since it has been close to 1 year. Feel free to claim it again if you did intend to work on it after all.
Most of the work was done already, and not much has changed (if anything) in the measuring tool, so this patch should still apply without much problems.
Hi, i am an outreachy applicant looking to contribute . I would like to work on it. It would be nice if you could assign it to me
Comment 23•6 years ago
|
||
Sure, I'll assign it to you now. Thanks for wanting to work on it.
Make sure you ask any questions here if you need any help.
In the meantime, you can probably get started by reading the docs at https://docs.firefox-dev.tools to make sure you know how get the source code, build it, and make changes to it (and test those changes).
Also, the patch attached here on this bug would be a good start for you. You should try to download it locally and apply it to your repository. Please let me know if this doesn't work anymore (I'm fairly sure it will work fine because the file that this patch changes is almost never touched these days).
Comment 24•6 years ago
|
||
Hi Asish, are you still planning on working on this bug? If you need more time, that is completely fine.
If, however, you do not plan on working on this, please let me know so it can be made available to others.
Comment 25•6 years ago
|
||
Unassigning this bug.
Updated•5 years ago
|
Comment 27•5 years ago
|
||
Yes I guess you can. I'm going to remove myself from the mentor field though, and forward your request to Razvan who, I think, would be a better person to put you on the right track here.
Comment 28•5 years ago
|
||
I am going to start working to create a patch by looking over the above discussion
Comment 29•5 years ago
|
||
Hi Ajitesh13,
Sorry for the very late reply. We are currently in the process of updating the measuring tool and other highlighters to support multi-process tabs. This may or may not interfere with your work on this bug, depending on what you end up changing.
You are free to take this bug. I will assign it to you.
Comment 30•5 years ago
|
||
Comment 31•5 years ago
|
||
@Razvan, I have a rough patch ready. shiftKey+arrowkeydown/arrowkeyup/arrowkeyupleft is working but, couldn't discover why shiftkey+arrowkeyright is not working. Please take a look at the patch and suggest changes
Updated•4 years ago
|
Comment 32•4 years ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Comment 33•4 years ago
|
||
Claim this bug. I wish to work on it
Updated•3 years ago
|
Assignee | ||
Comment 34•2 years ago
|
||
I'd like to pick up this bug. A problem that I notice is that the measuring tool anchors in the corner from which the box was drawn. This makes it unclear which way the box is going to resize when you begin to hit the arrows, aside from the fact that the label renders at the opposite corner from the origin (which is IMO an insufficient indicator). Ways around this:
- We could change the color of the handler at the origin corner while the Shift key is held, perhaps to blue.
- We could pick a corner, such as the upper-left, to always use as the origin while resizing with the keyboard shortcuts.
I am leaning towards the former. Open to any suggestions.
Assignee | ||
Comment 35•2 years ago
|
||
Assignee | ||
Comment 36•2 years ago
|
||
I have a WIP patch which gets the keybinds working, passes lint, and decouples the mouse coordinates from the rectangle coordinates so that the rectangle does not snap to the mouse when resizing with a keybind.
Still looking for insight on the UX concern in my previous comment. Another thing that'd be nice would be keybinds to move the X/Y-position of the rectangle, so that full control of the rectangle is had from the keyboard. These could be on the raw arrow keys, or perhaps Alt+arrows. Thoughts?
Assignee | ||
Comment 37•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Comment 38•2 years ago
|
||
Depends on D183092
Assignee | ||
Comment 39•2 years ago
|
||
Depends on D183093
Updated•2 years ago
|
Assignee | ||
Comment 40•2 years ago
|
||
I've submitted patches for review with tentative solutions to the issues I mentioned last night.
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 41•2 years ago
|
||
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 42•2 years ago
|
||
Depends on D183148
Updated•2 years ago
|
Comment 43•2 years ago
|
||
Comment 44•2 years ago
|
||
bugherder |
Reporter | ||
Comment 45•2 years ago
|
||
This is worth mentioning in https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/117.
Sebastian
Comment 46•2 years ago
|
||
Docs additions for this can be tracked in the following GitHub issue: https://github.com/mdn/content/issues/28754
Assignee | ||
Updated•2 years ago
|
Description
•