1263698 - Em dash separator between title and URL/action is incorrectly placed for URLs in RTL in the awesomebar popup

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Drew Willcoxon :adw]

The em dash separator is placed at the end of the URL instead of between the URL and title.  The problem is that we force the .ac-url box to always be LTR even in RTL, and the separator is inside .ac-url.

Comment 1

[Drew Willcoxon :adw]

Attachment: MozReview Request: Bug 1263698 - Correctly place the em dash separator between title and URL in awesomebar popup in RTL. r?mak

Review commit: https://reviewboard.mozilla.org/r/45563/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45563/

Comment 2

[Drew Willcoxon :adw]

Think the right way to fix this is to move the em dash separator out of the URL/action boxes and into a top-level box.

Comment 3

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c7e6f70d41c

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8740101 [details]
MozReview Request: Bug 1263698 - Correctly place the em dash separator between title and URL in awesomebar popup in RTL. r?mak

https://reviewboard.mozilla.org/r/45563/#review42349

LGTM.
As I previously said it's hard to review this kind of change if not by a simple code inspection and testing, so let's land it and test asap.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c285601ae929

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c285601ae929

Comment 7

[Cornel Ionce [:noni] [Hubs QA]]

The separator is now moved but it seems like both spaces are placed after it, instead of one before and one after. The separator is tied to the url.

See http://i.imgur.com/kxQYbHQ.png

Drew, it would take long to fix this?

Comment 8

[Drew Willcoxon :adw]

Thanks very much Cornel, I filed bug 1270670.  It's a simple fix.

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

Marking this verified since bug 1270670 was filled for the remaining issue.