Closed Bug 1263698 Opened 4 years ago Closed 4 years ago

Em dash separator between title and URL/action is incorrectly placed for URLs in RTL in the awesomebar popup

Categories

(Firefox :: Address Bar, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 48
Tracking Status
firefox48 --- verified

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

The em dash separator is placed at the end of the URL instead of between the URL and title.  The problem is that we force the .ac-url box to always be LTR even in RTL, and the separator is inside .ac-url.
Think the right way to fix this is to move the em dash separator out of the URL/action boxes and into a top-level box.
Comment on attachment 8740101 [details]
MozReview Request: Bug 1263698 - Correctly place the em dash separator between title and URL in awesomebar popup in RTL. r?mak

https://reviewboard.mozilla.org/r/45563/#review42349

LGTM.
As I previously said it's hard to review this kind of change if not by a simple code inspection and testing, so let's land it and test asap.
Attachment #8740101 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/c285601ae929
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Depends on: 1265066
The separator is now moved but it seems like both spaces are placed after it, instead of one before and one after. The separator is tied to the url.

See http://i.imgur.com/kxQYbHQ.png

Drew, it would take long to fix this?
Flags: needinfo?(adw)
Thanks very much Cornel, I filed bug 1270670.  It's a simple fix.
Flags: needinfo?(adw)
Marking this verified since bug 1270670 was filled for the remaining issue.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.