Scrolling the tab strip has wild behaviour on a MBP with touchpad

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
a year ago
6 months ago

People

(Reporter: jrmuizel, Assigned: mstange)

Tracking

unspecified
Firefox 48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

a year ago
It goes very fast from one side to the other. It is for example impossible to scroll by a single tab.

Ideally you could scroll the tab strip pixel by pixel just like other scrollable things.

Comment 1

a year ago
Is this a recent regression? I can't reproduce on beta...
Flags: needinfo?(jmuizelaar)
(Assignee)

Comment 2

a year ago
I can reproduce this on 45.0.1. It doesn't look like a regression to me.
(Reporter)

Comment 3

a year ago
Nope, we've had this problem for a long time.
Flags: needinfo?(jmuizelaar)
The summary of this bug kinda ends on a cliffhanger. With what?
Flags: needinfo?(jmuizelaar)
(Assignee)

Comment 5

a year ago
Created attachment 8740492 [details]
MozReview Request: Bug 1263975 - XUL scrollbox (e.g. the tab bar) should respond to pixel scrolls by pixel scrolling. r?enndeakin

Review commit: https://reviewboard.mozilla.org/r/45805/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45805/
(Assignee)

Updated

a year ago
Attachment #8740492 - Flags: review?(enndeakin)
(Reporter)

Updated

a year ago
Flags: needinfo?(jmuizelaar)
Summary: Scrolling the tab strip has wild behaviour on a MBP with → Scrolling the tab strip has wild behaviour on a MBP with touchpad
(Assignee)

Comment 6

a year ago
I don't think we gain anything from forcing scrolls to line up with the boundaries of the scrolled elements, for any type of scrollbox. I think we should allow pixel scrolling everywhere. There's one case where the decision maybe isn't completely clear, and that's menupopups: On OS X, if you have a native menu with lots of items so that it overflows, the native menu responds to touchpad scrolling by scrolling one item at a time. With this patch, in Firefox, overflowing menus will allow pixel scrolling. I think that's fine.

The patch treats wheel events with deltaMode DOM_DELTA_PAGE as line wheel events. I don't even know if there's a way to produce DOMSDELTA_PAGE wheel events.
Comment on attachment 8740492 [details]
MozReview Request: Bug 1263975 - XUL scrollbox (e.g. the tab bar) should respond to pixel scrolls by pixel scrolling. r?enndeakin

https://reviewboard.mozilla.org/r/45805/#review42967
Attachment #8740492 - Flags: review?(enndeakin) → review+

Comment 8

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/954189d579d5
This broke some tests like https://treeherder.mozilla.org/logviewer.html#?job_id=25819438&repo=mozilla-inbound

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b0628853f899
Flags: needinfo?(mstange)
(Assignee)

Comment 10

a year ago
Oops.
Flags: needinfo?(mstange)
(Assignee)

Comment 11

a year ago
Created attachment 8741917 [details] [diff] [review]
test adjustments

The test was testing that we were ignoring the pixel delta and only using the lineOrPageDelta. We're no longer doing that.
This changes the test so that it doesn't really matter which delta is respected.
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #8741917 - Flags: review?(masayuki)
Attachment #8741917 - Flags: review?(masayuki) → review+

Comment 12

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f46b25846856
https://hg.mozilla.org/integration/mozilla-inbound/rev/6963c6f6caac

Comment 13

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f46b25846856
https://hg.mozilla.org/mozilla-central/rev/6963c6f6caac
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48

Updated

a year ago
Depends on: 1251980

Updated

a year ago
Depends on: 1251987

Updated

a year ago
Depends on: 1266596
Maybe not strictly a bug, but this broke two addons which allowed switching tabs by scrolling the mouse wheel over the tabs (Fire gestures and Tab Wheel Scroll).

Comment 15

a year ago
(In reply to Avi Halachmi (:avih) from comment #14)
> Maybe not strictly a bug, but this broke two addons which allowed switching
> tabs by scrolling the mouse wheel over the tabs (Fire gestures and Tab Wheel
> Scroll).

Please file a followup bug with more details about what broke and ping the assignee of this bug there if there's an API issue?
Flags: needinfo?(avihpit)
I won't file a bug since I don't know if it's a bug. If Markus thinks it's a bug, he can file it.
Flags: needinfo?(avihpit)

Updated

10 months ago
Duplicate of this bug: 1167398
(Assignee)

Updated

10 months ago
Duplicate of this bug: 467868

Updated

6 months ago
See Also: → bug 1316505
You need to log in before you can comment on or make changes to this bug.