MozReview Request: Bug 1263975 - XUL scrollbox (e.g. the tab bar) should respond to pixel scrolls by pixel scrolling. r?enndeakin
58 bytes, text/x-review-board-request
3.99 KB, patch
|Details | Diff | Splinter Review|
It goes very fast from one side to the other. It is for example impossible to scroll by a single tab. Ideally you could scroll the tab strip pixel by pixel just like other scrollable things.
Is this a recent regression? I can't reproduce on beta...
I can reproduce this on 45.0.1. It doesn't look like a regression to me.
Nope, we've had this problem for a long time.
The summary of this bug kinda ends on a cliffhanger. With what?
Review commit: https://reviewboard.mozilla.org/r/45805/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45805/
Attachment #8740492 - Flags: review?(enndeakin)
Summary: Scrolling the tab strip has wild behaviour on a MBP with → Scrolling the tab strip has wild behaviour on a MBP with touchpad
I don't think we gain anything from forcing scrolls to line up with the boundaries of the scrolled elements, for any type of scrollbox. I think we should allow pixel scrolling everywhere. There's one case where the decision maybe isn't completely clear, and that's menupopups: On OS X, if you have a native menu with lots of items so that it overflows, the native menu responds to touchpad scrolling by scrolling one item at a time. With this patch, in Firefox, overflowing menus will allow pixel scrolling. I think that's fine. The patch treats wheel events with deltaMode DOM_DELTA_PAGE as line wheel events. I don't even know if there's a way to produce DOMSDELTA_PAGE wheel events.
Comment on attachment 8740492 [details] MozReview Request: Bug 1263975 - XUL scrollbox (e.g. the tab bar) should respond to pixel scrolls by pixel scrolling. r?enndeakin https://reviewboard.mozilla.org/r/45805/#review42967
Attachment #8740492 - Flags: review?(enndeakin) → review+
This broke some tests like https://treeherder.mozilla.org/logviewer.html#?job_id=25819438&repo=mozilla-inbound Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b0628853f899
The test was testing that we were ignoring the pixel delta and only using the lineOrPageDelta. We're no longer doing that. This changes the test so that it doesn't really matter which delta is respected.
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #8741917 - Flags: review?(masayuki)
3 years ago
Attachment #8741917 - Flags: review?(masayuki) → review+
Maybe not strictly a bug, but this broke two addons which allowed switching tabs by scrolling the mouse wheel over the tabs (Fire gestures and Tab Wheel Scroll).
(In reply to Avi Halachmi (:avih) from comment #14) > Maybe not strictly a bug, but this broke two addons which allowed switching > tabs by scrolling the mouse wheel over the tabs (Fire gestures and Tab Wheel > Scroll). Please file a followup bug with more details about what broke and ping the assignee of this bug there if there's an API issue?
I won't file a bug since I don't know if it's a bug. If Markus thinks it's a bug, he can file it.
You need to log in before you can comment on or make changes to this bug.