Closed Bug 1264684 Opened 4 years ago Closed 4 years ago

[rep tests] Add tests for grip-array rep

Categories

(DevTools :: Shared Components, enhancement, P1)

enhancement

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.3 - Jul 18
Tracking Status
firefox50 --- fixed

People

(Reporter: linclark, Assigned: linclark)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file, 1 obsolete file)

See Bug 1257552
Blocks: 1257552
Severity: normal → enhancement
Whiteboard: [devtools-html]
Flags: qe-verify-
Priority: -- → P2
Assignee: nobody → lclark
Attached patch Bug1264684.patch (obsolete) — Splinter Review
Attachment #8765477 - Flags: review?(odvarko)
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
So, if I understand correctly, this needs another bug report related to the missing provider, right?
(all outputs are empty atm)

Honza
Flags: needinfo?(lclark)
There is a bug, and this TODO in the file:

> // @TODO This is not how this feature should actually work
> // See Bug 1282463 - Reps: ensure that grip arrays work even when a provider is not provided

were you thinking of something else?
Flags: needinfo?(lclark)
Comment on attachment 8765477 [details] [diff] [review]
Bug1264684.patch

Review of attachment 8765477 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Lin Clark [:linclark] from comment #3)
> There is a bug, and this TODO in the file:
> 
> > // @TODO This is not how this feature should actually work
> > // See Bug 1282463 - Reps: ensure that grip arrays work even when a provider is not provided
Ah, good.

Honza
Attachment #8765477 - Flags: review?(odvarko) → review+
Iteration: 50.2 - Jul 4 → 50.3 - Jul 18
Attachment #8765477 - Attachment is obsolete: true
Comment on attachment 8769172 [details]
Bug 1264684 - [rep tests] Add tests for grip-array rep.

Carrying over the r+
Attachment #8769172 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/4089e4a43dc6
[rep tests] Add tests for grip-array rep. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4089e4a43dc6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.