1264692 - [rep tests] Add tests for object-with-url rep

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement, P1)

Description

[Lin Clark [:linclark]]

See Bug 1257552

Comment 1

[Lin Clark [:linclark]]

Attachment: Bug1264692.patch

:Honza, when I run the attached test I get Rep correctly selects ObjectWithURL - got "UndefinedRep", expected "ObjectWithURL". Do you know why this would be happening for that stub grip?

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Lin Clark [:linclark] from comment #1)
> Created attachment 8747682 [details] [diff] [review]
> Bug1264692.patch
> 
> :Honza, when I run the attached test I get Rep correctly selects
> ObjectWithURL - got "UndefinedRep", expected "ObjectWithURL". Do you know
> why this would be happening for that stub grip?
There are two things causing the failure:

1) The grip (or any other object) must be passed as 'object' prop into a rep.
const renderedRep = shallowRenderComponent(Rep, {object: gripStub});

2) The gripStub in the test has prop "class" set to "Window", which causes the Window rep to be picked. You need to remove it (in order to get the "ObjectWithURL").

Honza

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Forgot to add. The test in bug 1264700 should also be fixed since the grip is not passed in as 'object' props and the result is undefined (which is correct, by by coincidence).

Honza

Comment 4

[Lin Clark [:linclark]]

Attachment: Bug1264692.patch

Comment 5

[Lin Clark [:linclark]]

Attachment: Bug1264692.patch

Here's the test, including the TODO to test the link once it's implmented. 

I also removed the check for the grip.preview.kind property in getDescription since it's already checked in supportsObject, but I can revert that if you like.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8748285 [details] [diff] [review]
Bug1264692.patch

Review of attachment 8748285 [details] [diff] [review]:
-----------------------------------------------------------------

Please fix the URL. The test passes if the URL is correct and I don't see any other issues so, I am r+ it.

Honza

::: devtools/client/shared/components/reps/object-with-url.js
@@ +36,1 @@
>      },

I like this change

::: devtools/client/shared/components/test/mochitest/test_reps_object-with-url.html
@@ +42,5 @@
> +    // Test rendering
> +    const renderedComponent = renderComponent(ObjectWithURL.rep, { object: gripStub });
> +    ok(renderedComponent.className.includes("objectLink-Location"), "ObjectWithURL rep has expected class name");
> +    const innerNode = renderedComponent.querySelector(".objectPropValue");
> +    is(innerNode.textContent, "about:privatebrowsing", "ObjectWithURL rep has expected inner HTML structure and text content");

The URL is wrong and the test fails on it.

Comment 7

[Lin Clark [:linclark]]

Attachment: Bug1264692.patch

Thanks for catching that!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7fa2a19a9c53

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7fa2a19a9c53