Closed
Bug 1267259
Opened 8 years ago
Closed 8 years ago
Thunderbird: Unable to drag and drop attachments to OS file folder - caused by Core::DOM:Events
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: jorgk-bmo, Assigned: enndeakin)
References
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
1.25 KB,
patch
|
smaug
:
review+
jorgk-bmo
:
feedback+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Since bug 270292 we were able to drag multiple attachment to an OS folder. This feature is in TB 45 and it works. I am using TB 48.0a1 (2016-04-24) Daily and I can't even drag a single attachment any more. So something went bust somewhere. Alice, can you find a regression window for us?
Reporter | ||
Comment 1•8 years ago
|
||
Alice, just try to drag a single attachment from a message onto the desktop or some other folder. Thanking you in advance.
Flags: needinfo?(alice0775)
Comment 2•8 years ago
|
||
Regression window: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0891f0fa044cba28024849803e170ed7700e01e0&tochange=fc15477ce628599519cb0055f52cc195d640dc94 https://hg.mozilla.org/comm-central/pushloghtml?fromchange=aaf73ae87441&tochange=a5f12c8dc64f Suspect Bug 860857, Bug 1226977
Flags: needinfo?(alice0775)
Updated•8 years ago
|
Flags: needinfo?(enndeakin)
Assignee | ||
Comment 3•8 years ago
|
||
Can you check if this patch fixes things?
Flags: needinfo?(enndeakin)
Reporter | ||
Comment 4•8 years ago
|
||
Thanks, Neil. I will check this in the next few hours.
Comment 5•8 years ago
|
||
(In reply to Neil Deakin from comment #3) > Created attachment 8745008 [details] [diff] [review] > Add extra drag promise types to whitelist > > Can you check if this patch fixes things? I confirmed in a local win32 build that the attached patch (comment 3) fixes the problem.
Reporter | ||
Comment 6•8 years ago
|
||
Thanks, my VS2013 build is currently broken, I need to download VS2015 (7GB) first. I'll get to it tomorrow (midnight here now).
Keywords: regressionwindow-wanted
Reporter | ||
Updated•8 years ago
|
Component: Attachments → DOM: Events
Product: MailNews Core → Core
Reporter | ||
Comment 7•8 years ago
|
||
Neil, thanks for the patch. As Alice already said in comment #5, this fixes the problem. However, the patch didn't apply due to some white-space issues. I'll attach my version. Can you please get this reviewed and landed and also back-ported to FF 48 (Aurora) since the problem was caused there.
Attachment #8745008 -
Attachment is obsolete: true
Attachment #8745249 -
Flags: feedback+
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(enndeakin)
Reporter | ||
Updated•8 years ago
|
Summary: Unable to drag and drop attachments to OS file folder → Thunderbird: Unable to drag and drop attachments to OS file folder - caused by Core::DOM:Events
Reporter | ||
Comment 8•8 years ago
|
||
Oops, mis-edited that. Now it's right.
Attachment #8745249 -
Attachment is obsolete: true
Attachment #8745255 -
Flags: feedback+
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8745255 [details] [diff] [review] Add extra drag promise types to whitelist (made it apply) Windows and Mac use these types to specify the url and filename of downloads.
Flags: needinfo?(enndeakin)
Attachment #8745255 -
Flags: review?(bugs)
Updated•8 years ago
|
Attachment #8745255 -
Flags: review?(bugs) → review+
Reporter | ||
Updated•8 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 10•8 years ago
|
||
Neil, looks like the sheriffs haven't picked it up. Their rules also are the a try run needs to be attached. Can you simply push it to inbound. Thanks.
Flags: needinfo?(enndeakin)
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/54b1f93e6b73
Keywords: checkin-needed
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/54b1f93e6b73
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Reporter | ||
Comment 14•8 years ago
|
||
Comment on attachment 8745255 [details] [diff] [review] Add extra drag promise types to whitelist (made it apply) Approval Request Comment [Feature/regressing bug #]: Bug 860857 [User impact if declined]: Drag and drop of files from the Firefox download list (comment #9) or from Thunderbird's message attachment area to an operation system folder won't work. [Describe test coverage new/current, TreeHerder]: Manual test only. [Risks and why]: This was broken recently just before the branch day (Apr 25, 2016), so it should be fixed in the same cycle of bug that broke it. [String/UUID change made/needed]: None.
Attachment #8745255 -
Flags: approval-mozilla-aurora?
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → enndeakin
Reporter | ||
Comment 16•8 years ago
|
||
Gentle ping to get this landed on Aurora (and bug 1267612, too).
Flags: needinfo?(lhenry)
Comment 17•8 years ago
|
||
Comment on attachment 8745255 [details] [diff] [review] Add extra drag promise types to whitelist (made it apply) Fix for drag and drop from Downloads, it's been in nightly a while, OK to uplift to aurora.
Flags: needinfo?(lhenry)
Attachment #8745255 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 18•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/1769f2f6230e
You need to log in
before you can comment on or make changes to this bug.
Description
•