1267259 - Thunderbird: Unable to drag and drop attachments to OS file folder - caused by Core::DOM:Events

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Jorg K (CEST = GMT+2)]

Since bug 270292 we were able to drag multiple attachment to an OS folder.
This feature is in TB 45 and it works.

I am using TB 48.0a1 (2016-04-24) Daily and I can't even drag a single attachment any more.

So something went bust somewhere.

Alice, can you find a regression window for us?

Comment 1

[Jorg K (CEST = GMT+2)]

Alice, just try to drag a single attachment from a message onto the desktop or some other folder.
Thanking you in advance.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0891f0fa044cba28024849803e170ed7700e01e0&tochange=fc15477ce628599519cb0055f52cc195d640dc94
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=aaf73ae87441&tochange=a5f12c8dc64f

Suspect Bug 860857, Bug 1226977

Comment 3

[Neil Deakin]

Attachment: Add extra drag promise types to whitelist

Can you check if this patch fixes things?

Comment 4

[Jorg K (CEST = GMT+2)]

Thanks, Neil. I will check this in the next few hours.

Comment 5

[Alice0775 White]

(In reply to Neil Deakin from comment #3)
> Created attachment 8745008 [details] [diff] [review]
> Add extra drag promise types to whitelist
> 
> Can you check if this patch fixes things?

I confirmed in a local win32 build that the attached patch (comment 3) fixes the problem.

Comment 6

[Jorg K (CEST = GMT+2)]

Thanks, my VS2013 build is currently broken, I need to download VS2015 (7GB) first. I'll get to it tomorrow (midnight here now).

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: Add extra drag promise types to whitelist (made it apply)

Neil, thanks for the patch. As Alice already said in comment #5, this fixes the problem.

However, the patch didn't apply due to some white-space issues. I'll attach my version. Can you please get this reviewed and landed and also back-ported to FF 48 (Aurora) since the problem was caused there.

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: Add extra drag promise types to whitelist (made it apply)

Oops, mis-edited that. Now it's right.

Comment 9

[Neil Deakin]

Comment on attachment 8745255 [details] [diff] [review]
Add extra drag promise types to whitelist (made it apply)

Windows and Mac use these types to specify the url and filename of downloads.

Comment 10

[Jorg K (CEST = GMT+2)]

Neil, looks like the sheriffs haven't picked it up. Their rules also are the a try run needs to be attached. Can you simply push it to inbound. Thanks.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/54b1f93e6b73

Comment 12

[Jorg K (CEST = GMT+2)]

OK, done.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/54b1f93e6b73

Comment 14

[Jorg K (CEST = GMT+2)]

Comment on attachment 8745255 [details] [diff] [review]
Add extra drag promise types to whitelist (made it apply)

Approval Request Comment
[Feature/regressing bug #]: Bug 860857
[User impact if declined]: Drag and drop of files from the Firefox download list (comment #9) or from Thunderbird's message attachment area to an operation system folder won't work.
[Describe test coverage new/current, TreeHerder]: Manual test only.
[Risks and why]:
This was broken recently just before the branch day (Apr 25, 2016), so it should be fixed in the same cycle of bug that broke it.
[String/UUID change made/needed]: None.

Comment 16

[Jorg K (CEST = GMT+2)]

Gentle ping to get this landed on Aurora (and bug 1267612, too).

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8745255 [details] [diff] [review]
Add extra drag promise types to whitelist (made it apply)

Fix for drag and drop from Downloads, it's been in nightly a while, OK to uplift to aurora.

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1769f2f6230e