Firebug theme - Adjust UI of logs view in Console panel

RESOLVED WONTFIX

Status

P2
normal
RESOLVED WONTFIX
3 years ago
10 months ago

People

(Reporter: sebo, Unassigned)

Tracking

(Blocks: 1 bug)

51 Branch
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
When using the Firebug theme the console messages should use the formattings and icons of Firebug 2.

Sebastian
(Reporter)

Comment 1

2 years ago
Using the Firebug theme the UI of the Console panel still has some differences to the Firebug extension. See the attached screenshot for comparison.
Parts of the differences were noted in the Firebug discussion group[1].

Here's a list of differences, which should be adjusted:

- Background color is slightly darker
- Logged elements have bold tag names and they use different colors
- Source links are not bold and their line and column numbers are red (colors might be ok, though)
- Icons differ
- Groups have a white background and don't have borders around their contents
- Functions in stack are missing their call parameters and are red, source links show the full URL
- XHRs have a white background and are missing the HTTP status, load time and source link

Sebastian

[1] https://groups.google.com/d/msg/firebug/8ICvaq6gFhs/EQSzF2MlAAAJ
(Reporter)

Updated

2 years ago
Severity: enhancement → normal
Summary: Properly style console messages in Firebug theme → Firebug theme - Adjust UI of logs view in Console panel
Version: unspecified → 51 Branch
Thanks for the comparison
Priority: -- → P2

Comment 3

2 years ago
I think we might want to revisit the light/dark theme look to be more similar to Firebug. 
I like the following things from Firebug:
- color-codes the message icons (red for error, yellow for warning, blue for info)
- messages are clearly separated by separators
- the icons are bigger

We might want to take Safari's console as inspiration (which is pretty similar to Firebug).

Helen, what do you think ?
Flags: needinfo?(hholmes)
Blocks: 1267303
(Reporter)

Comment 4

2 years ago
If I'm not mistaken, Helen doesn't work for Mozilla anymore. So I remove the needinfo request for her.

I agree with your points, Tim. I'll try to provide a patch for that.

Sebastian
Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED
Flags: needinfo?(hholmes)
(In reply to Sebastian Zartner [:sebo] from comment #4)
> If I'm not mistaken, Helen doesn't work for Mozilla anymore. So I remove the
> needinfo request for her.
> 
> I agree with your points, Tim. I'll try to provide a patch for that.
> 
> Sebastian

There are some design notes here that should be consulted and followed for this patch. 
https://docs.google.com/document/d/1AJ7oHC7akXJiliheHjhFc4fTonaN31Eo_P2M8gssL8s/edit#
It would be also nice to clarify what the scope of the work will be. There are maybe 2 concerns - does this relate to the devtools photon work and what type of changes. For the latter, I believe we are working on the 3 points that ntim mentioned in comment 3. We should also rename the bug if so and block it on Bug 1389730 if so.
(Reporter)

Comment 7

2 years ago
(In reply to Gabriel [:gl] (ΦωΦ) from comment #5)
> There are some design notes here that should be consulted and followed for
> this patch. 
> https://docs.google.com/document/d/
> 1AJ7oHC7akXJiliheHjhFc4fTonaN31Eo_P2M8gssL8s/edit#

Thanks for sharing! I have requested access.

(In reply to Gabriel [:gl] (ΦωΦ) from comment #6)
> It would be also nice to clarify what the scope of the work will be. There
> are maybe 2 concerns - does this relate to the devtools photon work and what
> type of changes. For the latter, I believe we are working on the 3 points
> that ntim mentioned in comment 3.

When I filed this bug it was meant to only adjust the Firebug theme, but one point I heard a few times was that currently log and info messages use the same orange color as error messages, which is confusing. That's one important part I'd like to take in.
So, I'd do the changes of comment 1 (minus the last two points in that list, as they are content changes, which will be put in separate bugs) plus Tim's three changes mentioned in comment 3.

> We should also rename the bug if so and block it on Bug 1389730 if so.

As that are UI changes, they might be part of bug 1389730.

Sebastian
The Firebug theme was removed in Bug 1378108, so I am marking this report as WONTFIX.

Honza
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → WONTFIX

Updated

11 months ago
Assignee: sebastianzartner → nobody
(Reporter)

Comment 9

10 months ago
Actually, this bug also covered changes to the light and dark theme. See comment 3. Asking in bug 878519 whether they can be handled there.

Sebastian

Updated

10 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.