1270400 - [TV][Home] Press left arrow key on the first card in folder will navigate to filter

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)

Description

[Mike Lien[:mlien]]

[Description]
According to the latest UX spec(https://drive.google.com/open?id=0BwbmH5cX2W6Od0EwMXpSWlFwcDQ), if user press left arrow key on the first card in folder should have no any function

[Testing Steps]
1. Add a new folder with any card
2. Navigation to the first card in step 1's folder
3. Press left arrow key

[Expected result]
Should have no any function

[Actual result]
Will navigate to filter

[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/4698bb1d24fac0db76f1f16f144cf0dae4bc3c23
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/ccf59a9dda868db58b5d943e2c4235ead89f9344

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1270400_tv_prevent_folder_left_to_filter > mozilla-b2g:v2.6

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8752027 [details] [review]
[gaia] luke-chang:1270400_tv_prevent_folder_left_to_filter > mozilla-b2g:v2.6

Hi Rex,

It's another simple patch. There are two commits because it's based on bug 1270399. Could you please take a look, too? Thanks.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8752027 [details] [review]
[gaia] luke-chang:1270400_tv_prevent_folder_left_to_filter > mozilla-b2g:v2.6

Looks good. thanks!

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Oh, and by the way please modify your commit message. See my Github comment.

Comment 5

[Luke Chang [:lchang] (inactive)]

Thanks for the reminder. It has been updated.


landed on v2.6: https://github.com/mozilla-b2g/gaia/commit/9a3ed0cb72e84628ca6c2c3e5b9fc4f419059268

Comment 6

[Mike Lien[:mlien]]

verified and fixed with the latest build
2.6 simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/c5cceac45c13eab6a297074d55261610d8a0880f
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/425aaa9763aef80ec1f7e78079e410ee1ccc9e32