1270687 - Replace all naked 'new's of reference-counted classes with calls to MakeAndAddRef<T>

Status: NEW

(Core :: MFBT, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

This is needed to be able to do nice things such as the change in bug 1270638.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Let's discuss this on m.d.platform first, shall we?

Comment 2

[Daniel Holbert [:dholbert]]

Note, classes with private constructors require a bit of special handling & special consideration here - see bug 1186012 comment 2.

Comment 3

[Daniel Holbert [:dholbert]]

Also note for folks working on conversions in the spirit of this bug: along with MakeAndAddRef<T> in this bug's title, we now also have MakeRefPtr<T> (added in bug 1354642, after this bug here was filed), which arguably a bit easier to read and is just as good for many use cases.

It has the same benefit of instantly AddRef'ing. The only difference is the return type (RefPtr vs already_AddRefed), and in many cases it doesn't really matter which one we're returning.