Closed Bug 1270853 Opened 4 years ago Closed 4 years ago

Remove HTML5 video controls statistics

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file, 4 obsolete files)

Attached patch Patch (obsolete) — Splinter Review
I've heard reports from some of the developers who work on video playback for Gecko, as well as Dolske, that the statistics offered through the controls are unreliable/don't offer enough data to make them useful.

Instead of iterating on them right now it would be better to remove them. If we come across some new needs or different ideas of integrating them than we can pursue those at that time.
Attachment #8749656 - Flags: review?(gijskruitbosch+bugs)
Does keeping them interfere something? Otherwise I see no reason to remove them. Also besides Firefox developers these statistics could be useful for normal users and web developers.
Chris, do you have a response in regards to comment #1?
Flags: needinfo?(cpearce)
Attached patch Patch v1.1 (obsolete) — Splinter Review
Attachment #8749656 - Attachment is obsolete: true
Attachment #8749656 - Flags: review?(gijskruitbosch+bugs)
Attachment #8749788 - Flags: review?(gijskruitbosch+bugs)
I don't feel strongly about keeping the default video controls' playback stats; I certainly don't find they add much value.

We could rework them to be based on VideoPlaybackQuality.

Anthony has interest in video playback perf reporting/statistics. He may have an opinion here. We've been discussing how Gecko can provide more useful statistics to web devs. Once we've figured out a path there, we could add those new stats to the default video controls.
Flags: needinfo?(cpearce) → needinfo?(ajones)
Comment on attachment 8749788 [details] [diff] [review]
Patch v1.1

From a quick look this looks more or less OK, but it seems like we should also be removing:

https://dxr.mozilla.org/mozilla-central/rev/e5a10bc7dac4ee2453d8319165c1f6578203eac7/browser/base/content/content.js#721-727

In any case, we do also need consensus that removal is what we want to do here.
Attachment #8749788 - Flags: review?(gijskruitbosch+bugs) → review+
Dolske, where do you stand with removing the current implementation of the statistics until we have the reworked ones described in comment #4?
Flags: needinfo?(dolske)
Blocks: 1271768
I'm OK with just removing them. I don't think they're useful to a lot of people. Displaying video playback stats is a pretty advanced use case.
Flags: needinfo?(ajones)
I'll clear the needinfo and mark this as checkin-needed based on this bug being added as blocking bug 1271768.
Flags: needinfo?(dolske)
Keywords: checkin-needed
Needs rebasing (sorry :\)
Keywords: checkin-needed
This was the guilty party, not bug 1181055.
https://hg.mozilla.org/integration/fx-team/rev/976f7eede8229530b737f1ca7eb151a502b46bd3
Bug 1270853 - Remove HTML5 video controls statistics. r=gijs, r=bz for removing internal chrome/xbl attribute in webidl
https://hg.mozilla.org/mozilla-central/rev/976f7eede822
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
well, I certainly it was still there right now, as is it's the available option to display stats in full screen mode.

can we add it back?
missing wish in that above sentence :)
Depends on: 1318541
You need to log in before you can comment on or make changes to this bug.