Closed
Bug 1270929
Opened 8 years ago
Closed 8 years ago
Create mechanism to enable/disable specific switchboard experiments from an add-on
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox47 wontfix, firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: Margaret, Assigned: Margaret)
Details
Attachments
(4 files)
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta-
|
Details |
58 bytes,
text/x-review-board-request
|
sebastian
:
review+
ritu
:
approval-mozilla-aurora+
|
Details |
61 bytes,
text/x-github-pull-request
|
sebastian
:
review+
|
Details | Review |
15.80 KB,
patch
|
ritu
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
To allow for testers to try out specific experiments.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51281/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51281/
Attachment #8750033 -
Flags: review?(liuche)
Attachment #8750034 -
Flags: review?(s.kaspari)
Attachment #8750034 -
Flags: review?(liuche)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51283/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51283/
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8750035 -
Flags: review?(s.kaspari)
Comment 4•8 years ago
|
||
Comment on attachment 8750034 [details] MozReview Request: Bug 1270929 - (Part 2) Create Experiments.setOverride/clearOverride API to allow add-ons to force enable/disable experiments. r=liuche,sebastian https://reviewboard.mozilla.org/r/51283/#review48063 This is great!
Attachment #8750034 -
Flags: review?(s.kaspari) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8750035 [details] [review] PR to add ability to toggle experiments to switchboard experiments add-on Merged.
Attachment #8750035 -
Flags: review?(s.kaspari) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8750033 [details] MozReview Request: Bug 1270929 - (Part 1) Remove support for specifying UUID from intent extra. r=liuche https://reviewboard.mozilla.org/r/51281/#review48089
Attachment #8750033 -
Flags: review+
Assignee | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f379e961906f976c55f9a45724b91d8b2ed1c63d Bug 1270929 - (Part 1) Remove support for specifying UUID from intent extra. r=sebastian https://hg.mozilla.org/integration/fx-team/rev/cbeb65bea19cef6b91ef50e4e38b473630c984d6 Bug 1270929 - (Part 2) Create Experiments.setOverride/clearOverride API to allow add-ons to force enable/disable experiments. r=sebastian
Assignee | ||
Updated•8 years ago
|
Attachment #8750033 -
Flags: review?(liuche)
Assignee | ||
Updated•8 years ago
|
Attachment #8750034 -
Flags: review?(liuche)
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f379e961906f https://hg.mozilla.org/mozilla-central/rev/cbeb65bea19c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8750033 [details] MozReview Request: Bug 1270929 - (Part 1) Remove support for specifying UUID from intent extra. r=liuche Depends on uplifts for bug 1207719, bug 1261713, and bug 1262811. Approval Request Comment [Feature/regressing bug #]: This would allow us to properly test bug 1004734. [User impact if declined]: Much harder for QA to verify that a feature works properly. [Describe test coverage new/current, TreeHerder]: junit tests, tested locally on aurora build (currently preparing to test on beta as well). [Risks and why]: There is some risk that this could regress switchboard, which is an important feature for us, but it's not difficult to verify that switchboard works properly after these patches land. Also, the changes in this bug actually make testing easier. [String/UUID change made/needed]: None.
Attachment #8750033 -
Flags: approval-mozilla-beta?
Attachment #8750033 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•8 years ago
|
Attachment #8750034 -
Flags: approval-mozilla-beta?
Attachment #8750034 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 10•8 years ago
|
||
This one actually needs rebasing for beta, so I did that here.
Attachment #8750945 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•8 years ago
|
Attachment #8750034 -
Flags: approval-mozilla-beta?
status-firefox47:
--- → affected
status-firefox48:
--- → affected
Hi Margaret, I am just a bit concerned about the timing of this change. Can we let this one ride Aurora48 to Beta48 train and not uplift to 47? Also, this code just landed in Nightly and hasn't had any bake time. Thoughts?
Flags: needinfo?(margaret.leibovic)
Also regressions like bug 1262811 make me nervous. I really would prefer to let this bake and not uplift to Beta47.
Assignee | ||
Comment 13•8 years ago
|
||
(In reply to Ritu Kothari (:ritu) from comment #12) > Also regressions like bug 1262811 make me nervous. I really would prefer to > let this bake and not uplift to Beta47. That was caught immediately, and it was the only regression. The changes in this bug are the only ones that landed on Nightly recently, the rest have had plenty of bake time on 48. I'm fine with spending some time letting this bake on Nightly and Aurora before uplift, but there are big benefits here to be able to test these things on Beta, so I would still like us to consider uplifting.
Flags: needinfo?(margaret.leibovic)
(In reply to :Margaret Leibovic from comment #13) > (In reply to Ritu Kothari (:ritu) from comment #12) > > Also regressions like bug 1262811 make me nervous. I really would prefer to > > let this bake and not uplift to Beta47. > > That was caught immediately, and it was the only regression. The changes in > this bug are the only ones that landed on Nightly recently, the rest have > had plenty of bake time on 48. > > I'm fine with spending some time letting this bake on Nightly and Aurora > before uplift, but there are big benefits here to be able to test these > things on Beta, so I would still like us to consider uplifting. Hi Margaret, I understand. However, when we have done such changes e.g. for e10s experiment, for Hello/Pocket, we have let them bake over Nightly and ride the trains. I would really prefer to let this ride the Aurora 48 to Beta48 train (you still get 6 weeks jump). This kind of change really does not meet the Beta uplift bar. We have been struggling to try to minimize dot releases and quality issues for the past few releases. Lawrence and RelMan team would like to move to a model where Beta release only includes severe critical regressions, top crashers, sec-highs/sec-crits, perf and mlk issues. Do you still think this meets the bar?
Comment on attachment 8750033 [details] MozReview Request: Bug 1270929 - (Part 1) Remove support for specifying UUID from intent extra. r=liuche Approved for uplift to Aurora48. We decided not to uplift this to Beta47. We will let this one ride the Aurora48 to Beta48 train.
Attachment #8750033 -
Flags: approval-mozilla-beta?
Attachment #8750033 -
Flags: approval-mozilla-beta-
Attachment #8750033 -
Flags: approval-mozilla-aurora?
Attachment #8750033 -
Flags: approval-mozilla-aurora+
Attachment #8750034 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8750945 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
Comment 16•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/521f93a84891 https://hg.mozilla.org/releases/mozilla-aurora/rev/f5f954dcd9aa
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•