1271336 - [meta] ShutDownKill content process mitigation work

Status: RESOLVED DUPLICATE of bug 1279293

(Core :: DOM: Content Processes, defect)

Description

[Jim Mathies [:jimm]]

Of the total content crashes we experience when running under e10s, preliminary data indicates around 85% of these are triggered by the content process being terminated by the parent due to long shutdown times.


https://gist.github.com/chutten/870e97c789096edb2752a67b23d3a079

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

We'll have to figure out how far we want to go here. If a web page is running slowly, it's going to take some time to shut down the content process. We could try to stop all content JS. That would be a decent amount of work.

Comment 2

[Jim Mathies [:jimm]]

Why don't we turn this timeout + kill off on nightly and see how bad the problem is? I've been running with this for a day and I'm not seeing any issues.

Comment 3

[Jim Mathies [:jimm]]

dom.ipc.tabs.shutdownTimeoutSecs

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Wouldn't that just transform one of these ShutDownKill crashes into a shutdown hang in the parent process? I guess the difference is that we wait 60 seconds in the parent versus 5 seconds in the child. Maybe we could just boost the timeout to 15 seconds or something?

Comment 5

[Jim Mathies [:jimm]]

(In reply to Bill McCloskey (:billm) from comment #4)
> Wouldn't that just transform one of these ShutDownKill crashes into a
> shutdown hang in the parent process? I guess the difference is that we wait
> 60 seconds in the parent versus 5 seconds in the child. Maybe we could just
> boost the timeout to 15 seconds or something?

Yep, in triage we discussed moving it out a bit on Nightly to see if the ShutDownKill numbers fall off. IMHO content occasionally taking a little more than 5 seconds to shutdown doesn't surprise me. That timeout feels a little aggressive.

Comment 6

[Jim Mathies [:jimm]]

Here's a try push with the timeout turned off - 

https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&selectedJob=20665837

I don't see a lot of issues here. shutdown failures that do show up appear to be common intermitents.

Comment 7

[Gabriele Svelto [:gsvelto]]

I'll try and give this another spin. We kind-of papered over the problem in bug 1498942 but the crash volume we get is still significant with many crashes seemingly caused by general slowness. We can probably do better.