Closed Bug 1271394 Opened 4 years ago Closed 4 years ago

Enable all standard tests on projects/larch branch.

Categories

(Infrastructure & Operations :: CIDuty, task)

task
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
Tracking Status
firefox49 --- fixed

People

(Reporter: djvj, Assigned: aselagea)

Details

Attachments

(5 files)

We need all the standard tests that run on mozilla-inbound to be enabled on projects/larch.
Component: General Automation → Buildduty
QA Contact: catlee → bugspam.Callek
Assignee: nobody → aselagea
aselegea: I think this just means the same builds/tests as on mozilla-inbound
aselegea: what kmoir said is correct.  We'd like the same set of tests enabled on projects/larch as are enabled on mozilla-inbound.

Sorry if my initial wording was not very clear.
Thanks, will start working on enabling the tests on larch.
Attaching the patch to enable the same tests on larch as on m-i.
Attachment #8752216 - Flags: review?(kmoir)
Attached file larch-tests.txt
Looking at larch on treeherder, there don't seem to be any builds enabled.  Do they need to be enabled?
Attached file builders.txt
Oh, it seems the builders from the patch attached are also added. 
@Kannan: please let me know if they are also needed. Otherwise, I'll rework the patch to remove them.
Flags: needinfo?(kvijayan)
We do need the builds on treeherder.  I just checked and they don't seem to be enabled.  I'm not sure what you mean in the comment above.

The builders from which patch are added to where?  We need CI builds on every checkin on projects/larch, just like on m-i and m-c.
Flags: needinfo?(kvijayan)
(In reply to Kannan Vijayan [:djvj] from comment #9)
> We do need the builds on treeherder.  I just checked and they don't seem to
> be enabled.  I'm not sure what you mean in the comment above.
> 
> The builders from which patch are added to where?  We need CI builds on
> every checkin on projects/larch, just like on m-i and m-c.

Sorry for the confusion. 
What I meant to say is that the changes from'bug_1271394.patch' will also enable the builders listed in 'builders.txt' attachment (besides enabling the tests that you can see on 'larch-tests.txt').

The bug title only mentions 'tests' that we want to enable, so I guess Kim wanted to know if builders are also required: https://bugzilla.mozilla.org/show_bug.cgi?id=1271394#c7.

That being said, if we want the same builds and tests on larch as on mozilla-inbound, then I think the patch is ok for review :-)
Comment on attachment 8752216 [details] [diff] [review]
bug_1271394.patch

You need the builds enabled to trigger the tests and have binaries to run tests against.

Noticed that it appears we are running Linux64 builds on buildbot, shouldn't these be on taskcluster since they are turned off on buildbot in bug 1268542
Not sure about it, but in bug 1268542 we only disable the builders and tests for Linux64 debug. In 'builders.txt' attachment, I can see 'Linux x86-64 larch debug asan build' (which I'd say is for linux64-asan) and 'Linux x86-64 larch debug static analysis build' (which I don't seem to find where it belongs to).

Am I missing something here?
Flags: needinfo?(kmoir)
I think you will need to add something here
http://hg.mozilla.org/integration/mozilla-inbound/file/tip/testing/taskcluster/tasks/branches

so that builders that are disabled on buildbot will run on taskcluster and are enabled on larch just as they are for m-i
Flags: needinfo?(kmoir)
Attachment #8752216 - Flags: review?(kmoir) → review+
Attachment #8752216 - Flags: checked-in+
We'd like to run the same TC jobs on larch as on m-i. Adding a new folder for larch and the 'job_flags.yml' file for specific builds/tests (the same as with m-i).
Attachment #8754322 - Flags: review?(wcosta)
Comment on attachment 8754322 [details] [diff] [review]
[TC]bug_1271394.patch

Review of attachment 8754322 [details] [diff] [review]:
-----------------------------------------------------------------

Notice you have to add it to mozilla-taskcluster as well.
Attachment #8754322 - Flags: review?(wcosta) → review+
Whee!! Thank you.  I can see our first test build running.

I don't see MacOS or Android tests running.. are those not enabled?
I'm seeing the following build error in the logs for windows (and a few other architecures):

CalledProcessError: Command '['hg', 'unbundle', '--traceback', 'https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/bundles/larch.hg']' returned non-zero exit status 255

Link to example job:
https://treeherder.mozilla.org/#/jobs?repo=larch&selectedJob=470

Is this a repos issue or a build automation issue?
Forgot to needinfo you on last comment.  Please see Comment 18.
Flags: needinfo?(aselagea)
Nevermind, found the problem.  It was my issue in code.
Flags: needinfo?(aselagea)
Attachment #8754322 - Flags: checked-in+
https://hg.mozilla.org/mozilla-central/rev/7f6080fa6fc3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Product: Release Engineering → Infrastructure & Operations
You need to log in before you can comment on or make changes to this bug.