1271896 - No icon for Your friend has joined in standalone

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Screenshot showing the issue

[Affected versions]:
- Firefox 47 beta 7
- Latest Aurora 48.0a2
- Latest Nightly 49.0a1

[Affected platforms]:
- Windows 10 64-bit
- Mac OS X 10.10.5
- Ubuntu 14.04 32-bit

[Steps to reproduce]:
1. Start Firefox
2. Create a conversation and send the link to another browser/PC
3. Focus Standalone

[Expected result]:
- An icon is displayed for 'Your friend has joined.'

[Actual result]:
- No icon is displayed for 'Your friend has joined.'
Also I'm not sure if this message should be there since it's the first time the guest enters the room. The message should appear only when the Guest first enters the conversation, then later on the Host will enter as well.

[Regression range]:
- I'm unable to determine if this is a regression since it affects only Standalone.

[Additional notes]:
- I've attached a screenshot with the issue.
- This is only reproducible with 'loop.server' set to 'https://loop-dev.stage.mozaws.net/v0'

Comment 1

[GitHub Autolander Bot]

Attachment: [loop] fcampo:peer-join-image-1271896 > mozilla:master

Comment 2

[Fernando Campo (:fcampo)]

Definitely introduced when merging bug 1254097, I bloody forgot to add the image :facepalm:

Comment 3

[Fernando Campo (:fcampo)]

but it does not explain why is it only reproducible on dev server... how can you see the image on others?

(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #0)
> Also I'm not sure if this message should be there since it's the first time
> the guest enters the room. The message should appear only when the Guest
> first enters the conversation, then later on the Host will enter as well.
Notification should appear every time a user joins the room AFAIK, same as 'user has left' appears when someone leaves. Anyway, asking UX in case there's a need of change on behaviour

Comment 4

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8751673 [details] [review]
[loop] fcampo:peer-join-image-1271896 > mozilla:master

r=me with nit comments addressed

Comment 5

[Fernando Campo (:fcampo)]

merge from https://github.com/mozilla/loop/commit/c86879be343434b337f83d2536503c3894faf984 should fix that, but I'll wait to close the bug till Bogdan and Sevaan confirm that it's enough.

Comment 6

[Sevaan Franks [:sevaan]]

(In reply to Fernando Campo (:fcampo) from comment #3)
> Notification should appear every time a user joins the room AFAIK, same as
> 'user has left' appears when someone leaves. Anyway, asking UX in case
> there's a need of change on behaviour

This behavior is correct.

Comment 7

[Bogdan Maris, Desktop Test Engineering]

(In reply to Fernando Campo (:fcampo) from comment #5)
> merge from
> https://github.com/mozilla/loop/commit/
> c86879be343434b337f83d2536503c3894faf984 should fix that, but I'll wait to
> close the bug till Bogdan and Sevaan confirm that it's enough.

Looks good to me.

Comment 8

[Mark Banner (:standard8)]

https://github.com/mozilla/loop/commit/c86879be343434b337f83d2536503c3894faf984

Comment 9

[Mark Banner (:standard8)]

Clearing affected flags as this was with the standalone release.