Closed
Bug 1272056
Opened 9 years ago
Closed 9 years ago
Unlocalizable "devices connected" string added in bug 1259253
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 5.0+ | --- |
People
(Reporter: stef, Assigned: jhugman)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
https://github.com/mozilla/firefox-ios/pull/1738/commits/82a90c988444d35916ab973d645adeea93d20535#diff-acde690772668c1259217314efbefe8cR81
We need plurals to localize things,
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_and_Plurals
Without placeholder, constructs like number + string, are not even workaroundable for us.
|
||
Updated•9 years ago
|
tracking-fxios:
--- → ?
|
||
Updated•9 years ago
|
Assignee: nobody → jhugman
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8753917 -
Flags: review?(bmunar)
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8753917 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1826
LGTM - but I'm not really sure how l10n wants this to be formatted. Is this a correct way to localize this string, Stefan?
Flags: needinfo?(splewako)
Attachment #8753917 -
Flags: review?(bmunar) → review+
|
Reporter | |
Comment 3•9 years ago
|
||
Since we still don't support correct plural forms localization (bug 1181777) and 0 and 1 cases should be less likely, that would be the best option I think. Thank you.
Flags: needinfo?(splewako)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Merged and closed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Comment 5•9 years ago
|
||
This bug is closed, I don't understand the point of blocking bug 1277326 unless there are pending actionable items.
Given the timeline (14 days ago), this is in the v5.x branch already.
No longer blocks: 1277326
You need to log in
before you can comment on or make changes to this bug.
Description
•