Don't include task.h everywhere

RESOLVED FIXED in Firefox 49

Status

()

Core
IPC
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

unspecified
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

Created attachment 8751818 [details] [diff] [review]
Patch

Now that almost everywhere is using the XPCOM NewRunnableMethod, we can ditch this.
Attachment #8751818 - Flags: review?(nfroyd)
Comment on attachment 8751818 [details] [diff] [review]
Patch

Review of attachment 8751818 [details] [diff] [review]:
-----------------------------------------------------------------

I find it ironic that a patch titled "don't include task.h everywhere" is mostly adding #include "base/task.h".

Why do the places where you added the #include require it?  Does this actually reduce the number of files that depend on task.h?
Attachment #8751818 - Flags: review?(nfroyd) → review+
Yes, because message_loop.h is included in just about everything, and the replacements are almost entirely in .cpp files.
Oh, and the ones that still need it are generally using NewRunnableFunction, which we didn't yet consolidate with the XPCOM version (mostly because the chromium one takes arguments and the XPCOM one doesn't).
Assignee: nobody → khuey
Status: NEW → ASSIGNED
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2)
> Yes, because message_loop.h is included in just about everything, and the
> replacements are almost entirely in .cpp files.

The inclusion of message_loop.h everywhere seems suboptimal. :(
(In reply to Nathan Froyd [:froydnj] from comment #4)
> (In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2)
> > Yes, because message_loop.h is included in just about everything, and the
> > replacements are almost entirely in .cpp files.
> 
> The inclusion of message_loop.h everywhere seems suboptimal. :(

Agreed.  We'll get there.

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a5390192f94
Whiteboard: btpp-active

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5a5390192f94
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Depends on: 1273312
Depends on: 1273520
You need to log in before you can comment on or make changes to this bug.