1272415 - Don't include task.h everywhere

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Now that almost everywhere is using the XPCOM NewRunnableMethod, we can ditch this.

Comment 1

[Nathan Froyd [:froydnj]]

Comment on attachment 8751818 [details] [diff] [review]
Patch

Review of attachment 8751818 [details] [diff] [review]:
-----------------------------------------------------------------

I find it ironic that a patch titled "don't include task.h everywhere" is mostly adding #include "base/task.h".

Why do the places where you added the #include require it?  Does this actually reduce the number of files that depend on task.h?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yes, because message_loop.h is included in just about everything, and the replacements are almost entirely in .cpp files.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Oh, and the ones that still need it are generally using NewRunnableFunction, which we didn't yet consolidate with the XPCOM version (mostly because the chromium one takes arguments and the XPCOM one doesn't).

Comment 4

[Nathan Froyd [:froydnj]]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #2)
> Yes, because message_loop.h is included in just about everything, and the
> replacements are almost entirely in .cpp files.

The inclusion of message_loop.h everywhere seems suboptimal. :(

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Nathan Froyd [:froydnj] from comment #4)
> (In reply to Kyle Huey [:khuey] ([e-mail]) from comment #2)
> > Yes, because message_loop.h is included in just about everything, and the
> > replacements are almost entirely in .cpp files.
> 
> The inclusion of message_loop.h everywhere seems suboptimal. :(

Agreed.  We'll get there.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a5390192f94

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5a5390192f94