1273012 - Bookmarks popup would not scroll with mouse wheel when mouse pointer on a folder

Status: REOPENED

(Core :: Widget, defect, P3)

Description

[Alice0775 White]

Attachment: test bookmarks

[Tracking Requested - why for this release]: I cannot scroll bookmarks menu due to regression. (big mistake by Fx-team)


This is very annoyance bug.
To scroll bookmarks menuopup, I always have to be concerned about the position of the mouse.

Steps to reproduce:
1. Bookmark sufficient number (e.g. 100) and also sufficient number of folder
2. Open Bookmarks menupopup
   --- the folder will be opened automatically and instantly (i.e., ui.submenuDelay  300ms)
3. Try scroll the menupopup to the bottom with mouse wheel

Actual Results:
Cannot scroll. i.e, cnnot open bookmark which is out of view.


Expected Results:
Menu should can be scrolled even if folder is opened.

Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=c6e90a3857c019e418c113f31dec86ca43e60243&tochange=4cab5471b2fa42dd7d0560f8f35dcc4e82a9414e

Regressed by:
4cab5471b2fa	Gijs Kruitbosch — Bug 982121 - consume wheel events when popups are open, r=enndeakin

Comment 1

[Alice0775 White]

Google chrome can scroll the menupopup even if folder is opened.

Comment 2

[Marcia Knous [:marcia]]

Going to track for 48/49 based on the fact this makes it difficult to scroll bookmarks. Should this be moved to the Core | Widget component to get it out of the untriaged state? And I think the 49 flag should be set to affected instead of unaffected?

Comment 3

[Alice0775 White]

oops.

Comment 4

[Alice0775 White]

oops.

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

From what I understand, this is done on purpose, based on the UX bug 982121 comment 18.  Gijs, can you verify?  If that's the case, we should wontfix this.

Comment 6

[:Gijs (he/him)]

(In reply to Milan Sreckovic [:milan] from comment #5)
> From what I understand, this is done on purpose, based on the UX bug 982121
> comment 18.  Gijs, can you verify?  If that's the case, we should wontfix
> this.

I defer to Neil and Jim on this. Feels like the parent menupopup could maybe be scrollable, but I don't know if that's feasible without "unfixing" 982121. Even so, the behaviour as it exists on 45 also doesn't seem particularly great, with the open submenu being left hanging in space while you scroll the parent menu. IE on win10 doesn't let you scroll the bookmarks menu at all, irrespective of whether a submenu is open or not. Not sure if there's other apps with a 'native' UI that we could get inspiration from about how this is "supposed" to work.

That said, this also doesn't seem like a big deal - if you're using the mouse to navigate these big menus, you already have to think about your mouse position and this doesn't seem like a big deal. Doesn't need to track a release, IMO.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

OK, sounds like we know we don't want to fix this at the expense of un-fixing 982121, and it's a question of whether we can get both done.

Comment 8

[Neil Deakin]

Attachment: Proof of concept

So we should hide child menus when scrolling a parent menu.

This is a proof of concept patch if someone wants to work on this.

It is for Mac only. It will need to be extended to other platforms, and also be limited to menus only.

Comment 10

[Cirno]

Keep in mind, if bookmark list consist only of folders and some of folder submenu suddenly opened, there is no way to close it or scroll with mouse at all

Comment 11

[Simple]

This feature is working well with Google Chrome and FireFox 47.01 and below!!

Comment 12

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 13

[Alice0775 White]

backing  out of bug 982121 is needed

Comment 14

[Julien Cristau [:jcristau] (back April 22)]

We've shipped 48 and 49 with this change, it doesn't look like it warrants tracking for 50.

Comment 15

[Gerry Chang [:gchang]]

Hi :Gijs,
Can you help to take a look at this bug since it's related to bug 982121?

Comment 16

[:Gijs (he/him)]

(In reply to Gerry Chang [:gchang] from comment #15)
> Hi :Gijs,
> Can you help to take a look at this bug since it's related to bug 982121?

I'm busy with other things right now, so I don't have time to do that at this point.

Comment 17

[Alice0775 White]

(In reply to :Gijs Kruitbosch from comment #16)
> (In reply to Gerry Chang [:gchang] from comment #15)
> > Hi :Gijs,
> > Can you help to take a look at this bug since it's related to bug 982121?
> 
> I'm busy with other things right now, so I don't have time to do that at
> this point.

Just remove the problem patch.

Comment 18

[:Gijs (he/him)]

(In reply to Alice0775 White from comment #17)
> (In reply to :Gijs Kruitbosch from comment #16)
> > (In reply to Gerry Chang [:gchang] from comment #15)
> > > Hi :Gijs,
> > > Can you help to take a look at this bug since it's related to bug 982121?
> > 
> > I'm busy with other things right now, so I don't have time to do that at
> > this point.
> 
> Just remove the problem patch.

I don't think that the severity of this problem justifies regressing bug 982121.

Comment 19

[Alice0775 White]

Unable to scroll bookmarks menupopup with mouse wheel. 
So, unable to access bookmarks of long menupopup.


Bug 982121 did fix only visual layout problem. 
However, Bug 982121 breaks basic function of bookmarks menupopup.

I think the later one is more severity problem.

Comment 20

[:Gijs (he/him)]

(In reply to Alice0775 White from comment #19)
> Unable to scroll bookmarks menupopup with mouse wheel. 
> So, unable to access bookmarks of long menupopup.

There are scroll buttons at the ends of the popup, and you can use the keyboard, so this is not true. You can no longer use the mousewheel to navigate the menu, when a child menu is open. That's a lot less sever than "it is impossible to access bookmarks".

We just disagree about the severities of the issues here.

Comment 21

[Alice0775 White]

Add ux-tone as well as regression.

User do not know why mouse wheel does not work?

Comment 22

[Alice0775 White]

No more

Comment 23

[:Gijs (he/him)]

This should be fixed. I just don't have time to do it right now. That's not the same as wontfix.

Comment 24

[Julien Cristau [:jcristau] (back April 22)]

This regression first shipped in 48, doesn't sound like it's major enough for us to track.

Comment 25

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix for 53, as we are in the last week of the 53 beta cycle.

Comment 26

[Julien Cristau [:jcristau] (back April 22)]

Mass wontfix for bugs affecting firefox 52.

Comment 27

[jpdraven]

The bug is affecting folders in your bookmarks folder only from what I have experienced.

I have a ton of bookmarks, and as well, folders. 

My folders are at the TOP of my bookmark menu.

Individual bookmarks beneath them

I can not scroll with the mouse wheel doen the menu, past the folders to the individula bookmarks. 

ALSO, by creating a folder, dropping all my existing folders in there, you can't scroll the folders created in there either.

This is a bug with how FF sees and scrolls folders specifically.

Version 47 is the last version to seamlessly work, EVERY version above it has broke this feature that has worked since FF v1

I emplore you to fix this as creating folders in bookmarks has always been a common thing, and a highly used thing that needs to be fixed.

Comment 28

[Jonathan Watt [:jwatt]]

Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)

Comment 29

[Alice0775 White]

I don't expect this to be fixed, not even by Proton.... :(

Comment 30

[Alice0775 White]

Now Proton menu has too much padding for bookmarks menu(See Bug 1707430).
So, I'm encountering this problem more often.

Please fix this bug!!!

Comment 33

[Dave Labrecque]

This bug is eight years old?

Sorry to be such a newbie, but why would this be?