1273579 - Move GenerateCSS2PropertiesWebIDL.py invocation to moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

This is similar to bug 1272488 - we just have to reconfigure the python script to put things in functions and invoke CPP from there.

Comment 1

[Michael Shal [:mshal]]

Attachment: MozReview Request: Bug 1273579 - Create main() function in GenerateCSS2PropertiesWebIDL.py; r?ted

Review commit: https://reviewboard.mozilla.org/r/53258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53258/

Comment 2

[Michael Shal [:mshal]]

Attachment: MozReview Request: Bug 1273579 - Move GenerateCSS2PropertiesWebIDL.py invocation to moz.build; r?ted

Review commit: https://reviewboard.mozilla.org/r/53260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53260/

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8753429 [details]
MozReview Request: Bug 1273579 - Create main() function in GenerateCSS2PropertiesWebIDL.py; r?ted

https://reviewboard.mozilla.org/r/53258/#review55832

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8753430 [details]
MozReview Request: Bug 1273579 - Move GenerateCSS2PropertiesWebIDL.py invocation to moz.build; r?ted

https://reviewboard.mozilla.org/r/53260/#review55834

::: dom/bindings/Makefile.in:13
(Diff revision 1)
>  
>  # Generated by moz.build
>  include webidlsrcs.mk
>  
>  # These come from webidlsrcs.mk.
>  # TODO Write directly into backend.mk.

We should probably turn this TODO into a bug if one is not already filed.

::: dom/bindings/Makefile.in:19
(Diff revision 1)
>  CPPSRCS += $(globalgen_sources) $(unified_binding_cpp_files)
>  
>  include $(topsrcdir)/config/rules.mk
>  
>  # TODO This list should be emitted to a .pp file via
>  # GenerateCSS2PropertiesWebIDL.py.

Just like the other bug, this is doable now, but it'd be fine as a followup. I guess you probably want to write a function to run CPP and extract the filenames from the output, and reuse that in both places?

Comment 5

[Michael Shal [:mshal]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> ::: dom/bindings/Makefile.in:13
> (Diff revision 1)
> >  
> >  # Generated by moz.build
> >  include webidlsrcs.mk
> >  
> >  # These come from webidlsrcs.mk.
> >  # TODO Write directly into backend.mk.
> 
> We should probably turn this TODO into a bug if one is not already filed.

Filed bug 1281618.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c51566c47110
Create main() function in GenerateCSS2PropertiesWebIDL.py; r=ted
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c89b1b05a55
Move GenerateCSS2PropertiesWebIDL.py invocation to moz.build; r=ted

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c51566c47110
https://hg.mozilla.org/mozilla-central/rev/2c89b1b05a55