1274374 - add support for /update/6 URLs

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[[e-mail] (:bhearsum)]

These are being added for CPU features in https://bugzilla.mozilla.org/show_bug.cgi?id=1271761, we'll need support on the server before that lands.

Comment 1

[[e-mail] (:bhearsum)]

Unlike other recent URL changes, this one will involve adding a new column to the database, too. The new URL is:
https://aus5.mozilla.org/update/4/%PRODUCT%/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%SYSTEM_CAPABILITIES%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml

The %SYSTEM_CAPABILITIES% section will currently have information about CPU features that the system supports, such as SSE or SSE2. In the future it may include other things. I suggest we treat this like OS_VERSION and do simple substring matches on it.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to Ben Hearsum (:bhearsum) from comment #1)
> Unlike other recent URL changes, this one will involve adding a new column
> to the database, too. The new URL is:
> https://aus5.mozilla.org/update/4/%PRODUCT%/%VERSION%/%BUILD_ID%/
> %BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%SYSTEM_CAPABILITIES%/
> %DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml

To avoid confusion, the path of this url should start /update/6 (to match the summary).

Comment 3

[[e-mail] (:bhearsum)]

Attachment: add support for /update/6/ URLs

Details in the PR.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: add UI to manage system capabilities

Comment 5

[Robert Strong (they/them - no direct email)]

Note regarding "Right now, it looks like it could be unknown, error, MMX, SSE, SSE2, or SSE3 based on my read of https://bug1271761.bmoattachments.org/attachment.cgi?id=8754952 "

It will be NA for platforms other than Windows until those platforms need values in this field.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/4219832bf5c94b5faa39ec4c4ce8daca8fbf6a35
bug 1274374: add support for /update/6 URLs (#84). r=nthomas

Comment 7

[[e-mail] (:bhearsum)]

While testing this out in dev I realized that the way I implemented the matching (simple substring matching) means we can't just filter on "SSE" :(. I'm going to have to do a small follow-up that switches this to full string matching.

Comment 8

[[e-mail] (:bhearsum)]

Attachment: fix system capability matching

Nick, apologies for the follow-up here. I had the substring matching logic backwards in my head when I wrote the original patch =\.

Comment 9

[[e-mail] (:bhearsum)]

rstrong and I verified this in dev, and I pushed to prod and reverified there. All done here.