1275040 - [e10s] Block e10s on OSX 10.6 - 10.8

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

10.6 - 10.8 support is ending soon, and the intersection of 10.6-8 and e10s would only happen for at most one release (Firefox 48).

Since there are some crash issues affecting 10.6 - 10.8 specifically, the simplest to do is to not run e10s on these versions

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: MozReview Request: Bug 1275040 - Actually block e10s on OS X 10.8. r=jimm

Review commit: https://reviewboard.mozilla.org/r/54698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54698/

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8755622 [details]
MozReview Request: Bug 1275040 - Actually block e10s on OS X 10.8. r=jimm

https://reviewboard.mozilla.org/r/54698/#review51780

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/94bc94b96176

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/94bc94b96176

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8755622 [details]
MozReview Request: Bug 1275040 - Actually block e10s on OS X 10.8. r=jimm

Approval Request Comment
[Feature/regressing bug #]: blocks e10s on OS X 10.6 - 10.8, on all channels
[User impact if declined]: 10.6 - 10.8 support is deprecated in 49, but for 48 it's still supported. However the plan is to not support e10s there just for one release
[Describe test coverage new/current, TreeHerder]: landed in central
[Risks and why]: limited to activating/not activating e10s on OS X
[String/UUID change made/needed]: the patch has an unlocalized string "OS X 10.6 - 10.8" to be displayed in about:support in case e10s is blocked.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8755622 [details]
MozReview Request: Bug 1275040 - Actually block e10s on OS X 10.8. r=jimm

make sense too, taking it

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/acc1985e7895

Comment 8

[ovidiu boca[:Ovidiu]]

Build ID 	20160530004020

I verified this fix on Mac OS X 10.6, 10.7 and 10.8 with the latest Aurora build and here are the results:

On Mac OS X 10.6 and 10.7 the fix works as expected, the check box for multi process is grayed out and it can't be activated, I also tried to activate e10s from about:config setting the "browser.tabs.remote.autostart" to false but with no success like expected. 


But on Mac OS X 10.8 the problem is not fixed. The check box for multi process is not grayed out, you can enable and disabled the e10s. 

Please let me know if anything else is needed from my side.

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Thank you for noticing this. I got confused since the function to check versions uses the codenames instead of version numbers, and the code ended up blocking only up to 10.7 (Lion) instead of 10.8 (Mountain Lion). 

The first supported version should actually be Mavericks (10.9)

Comment 10

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8755622 [details]
MozReview Request: Bug 1275040 - Actually block e10s on OS X 10.8. r=jimm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54698/diff/1-2/

Comment 11

[:Felipe Gomes (needinfo for replies!)]

Attachment: follow-up, actually block 10.8

Hmm MozReview is not playing nicely with this follow-up, so let's go through normal bugzilla procedures

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/6fb5bb73ea6a
Actually block e10s on OS X 10.8. r=jimm

Comment 13

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8758013 [details] [diff] [review]
follow-up, actually block 10.8

Approval Request Comment
[Feature/regressing bug #]: follow-up to this bug
[User impact if declined]: previous patch blocked up to 10.7 (Lion) instead of 10.8 (Mountain Lion)
[Describe test coverage new/current, TreeHerder]: landed in fx-team
[Risks and why]: contained to the e10s block for osx
[String/UUID change made/needed]: none

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6fb5bb73ea6a

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8758013 [details] [diff] [review]
follow-up, actually block 10.8

Next time, please open a new bug for a follow up.
It makes life of sheriffs and release managers harder

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/df5a45f1a3e7

Comment 17

[ovidiu boca[:Ovidiu]]

I verified this on Mac OS X 10.6, 10.7 and 10.8 with Firefox DeveloperEdition 48.0a2 (2016-06-03) and it works as expected.