[e10s] Block e10s on OSX 10.6 - 10.8

VERIFIED FIXED in Firefox 48

Status

()

Firefox
General
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

48 Branch
Firefox 49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10sm9+, firefox48 verified, firefox49 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
10.6 - 10.8 support is ending soon, and the intersection of 10.6-8 and e10s would only happen for at most one release (Firefox 48).

Since there are some crash issues affecting 10.6 - 10.8 specifically, the simplest to do is to not run e10s on these versions
(Assignee)

Comment 1

2 years ago
Created attachment 8755622 [details]
MozReview Request: Bug 1275040 - Actually block e10s on OS X 10.8. r=jimm

Review commit: https://reviewboard.mozilla.org/r/54698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54698/
Attachment #8755622 - Flags: review?(jmathies)

Updated

2 years ago
tracking-e10s: ? → m9+

Comment 2

2 years ago
Comment on attachment 8755622 [details]
MozReview Request: Bug 1275040 - Actually block e10s on OS X 10.8. r=jimm

https://reviewboard.mozilla.org/r/54698/#review51780
Attachment #8755622 - Flags: review?(jmathies) → review+
(Assignee)

Updated

2 years ago
Depends on: 1275738

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/94bc94b96176
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
(Assignee)

Comment 5

2 years ago
Comment on attachment 8755622 [details]
MozReview Request: Bug 1275040 - Actually block e10s on OS X 10.8. r=jimm

Approval Request Comment
[Feature/regressing bug #]: blocks e10s on OS X 10.6 - 10.8, on all channels
[User impact if declined]: 10.6 - 10.8 support is deprecated in 49, but for 48 it's still supported. However the plan is to not support e10s there just for one release
[Describe test coverage new/current, TreeHerder]: landed in central
[Risks and why]: limited to activating/not activating e10s on OS X
[String/UUID change made/needed]: the patch has an unlocalized string "OS X 10.6 - 10.8" to be displayed in about:support in case e10s is blocked.
Attachment #8755622 - Flags: approval-mozilla-aurora?
status-firefox48: --- → affected
Comment on attachment 8755622 [details]
MozReview Request: Bug 1275040 - Actually block e10s on OS X 10.8. r=jimm

make sense too, taking it
Attachment #8755622 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/acc1985e7895
status-firefox48: affected → fixed

Comment 8

2 years ago
Build ID 	20160530004020

I verified this fix on Mac OS X 10.6, 10.7 and 10.8 with the latest Aurora build and here are the results:

On Mac OS X 10.6 and 10.7 the fix works as expected, the check box for multi process is grayed out and it can't be activated, I also tried to activate e10s from about:config setting the "browser.tabs.remote.autostart" to false but with no success like expected. 


But on Mac OS X 10.8 the problem is not fixed. The check box for multi process is not grayed out, you can enable and disabled the e10s. 

Please let me know if anything else is needed from my side.
Flags: needinfo?(felipc)
(Assignee)

Comment 9

2 years ago
Thank you for noticing this. I got confused since the function to check versions uses the codenames instead of version numbers, and the code ended up blocking only up to 10.7 (Lion) instead of 10.8 (Mountain Lion). 

The first supported version should actually be Mavericks (10.9)
Status: RESOLVED → REOPENED
Flags: needinfo?(felipc)
Resolution: FIXED → ---
(Assignee)

Comment 10

2 years ago
Comment on attachment 8755622 [details]
MozReview Request: Bug 1275040 - Actually block e10s on OS X 10.8. r=jimm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54698/diff/1-2/
Attachment #8755622 - Attachment description: MozReview Request: Bug 1275040 - Block e10s from being activated in OS X 10.6 - 10.8 in all channels, as support for those versions will be removed soon. r=jimm → MozReview Request: Bug 1275040 - Actually block e10s on OS X 10.8. r=jimm
(Assignee)

Comment 11

2 years ago
Created attachment 8758013 [details] [diff] [review]
follow-up, actually block 10.8

Hmm MozReview is not playing nicely with this follow-up, so let's go through normal bugzilla procedures
Attachment #8758013 - Flags: review?(jmathies)
(Assignee)

Updated

2 years ago
Depends on: 1276723
No longer depends on: 1276723
See Also: → bug 1276723

Updated

2 years ago
Attachment #8758013 - Flags: review?(jmathies) → review+

Comment 12

2 years ago
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/6fb5bb73ea6a
Actually block e10s on OS X 10.8. r=jimm
status-firefox48: fixed → affected
(Assignee)

Comment 13

2 years ago
Comment on attachment 8758013 [details] [diff] [review]
follow-up, actually block 10.8

Approval Request Comment
[Feature/regressing bug #]: follow-up to this bug
[User impact if declined]: previous patch blocked up to 10.7 (Lion) instead of 10.8 (Mountain Lion)
[Describe test coverage new/current, TreeHerder]: landed in fx-team
[Risks and why]: contained to the e10s block for osx
[String/UUID change made/needed]: none
Attachment #8758013 - Flags: approval-mozilla-aurora?

Comment 14

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6fb5bb73ea6a
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
Comment on attachment 8758013 [details] [diff] [review]
follow-up, actually block 10.8

Next time, please open a new bug for a follow up.
It makes life of sheriffs and release managers harder
Attachment #8758013 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 16

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/df5a45f1a3e7
status-firefox48: affected → fixed
I verified this on Mac OS X 10.6, 10.7 and 10.8 with Firefox DeveloperEdition 48.0a2 (2016-06-03) and it works as expected.
Status: RESOLVED → VERIFIED

Updated

2 years ago
status-firefox48: fixed → verified
status-firefox49: fixed → verified
(Assignee)

Updated

2 years ago
Blocks: 1278356
You need to log in before you can comment on or make changes to this bug.