Closed
Bug 1275356
Opened 9 years ago
Closed 9 years ago
Fix newlines in gen-css-properties.py on Windows
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: mshal, Assigned: mshal)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
When this was moved to moz.build in bug 1256033, I didn't realize that Windows would get '\r\n' when invoking cpp, which results in '\r\r\n' being written out for newlines in css_properties.js. This doesn't seem to break anything, but I noticed it when doing bug 1275355.
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54914/
Attachment #8755971 -
Flags: review?(cmanchester)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8755971 [details]
MozReview Request: Bug 1275356 - Fix newlines in gen-css-properties.py on Windows; r?chmanchester
https://reviewboard.mozilla.org/r/54914/#review51602
Attachment #8755971 -
Flags: review?(cmanchester) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
|
|
||
Updated•9 years ago
|
Blocks: nomakefiles
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•