127699 - Disable UI for zoom, print, and landscape/postscript on Unix

Status: VERIFIED FIXED

(Core :: Print Preview, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

Once bug 127627 is fixed, zoom and landscape/portrait switching will no longer
work on Unix.  Printing from print preview already does not work (bug 126802).

Please disable the UI for this functionality on Unix for 0.9.9.  The current
state of affairs will look pretty unprofessional and, imo, will lead to slews of
bug reports like "When I click the arrow the number changes but the page does
not zoom!"

Comment 1

[Samir Gehani]

Nominating for us to take the interim measure.

Comment 2

[Peter Trudelle]

Where is the bug report to restore this funcationality?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Bug 127810 filed

Comment 4

[Samir Gehani]

Nav triage team: nsbeta1+

Comment 5

[Asa Dotzler [:asa]]

Samir, this is going to cause a flood of bug reports. Are you going to be able
to get to this in thenext couple of days for 0.9.9?

Comment 6

[Samir Gehani]

Asa, I plan on coming up with a patch today.

Comment 7

[Samir Gehani]

Attachment: Hide the print button, scaling widgets, and orientation widgets on Unices.

r=law
sr=jag 

Changed to pass string "true" instead of boolean true in setAttribute() per
jag.
Changed to use appVersion instead of the customizable userAgent per law.

Comment 8

[Roland Mainz]

Comment on attachment 71966 [details] [diff] [review]
Hide the print button, scaling widgets, and orientation widgets on Unices.

AFAIK we have a prefs which should control whether a printer device can have
more than one instance... I can't remember the name... rods ?

We should use that instead of |navigator.appVersion.indexOf("X11")| ...

Comment 9

[Roland Mainz]

Found it... it's (AFAIK) |pref("print.whileInPrintPreview", false);| we should
rely on... then it's easy to enable this later again...

Comment 10

[Samir Gehani]

a=asa

Checked in.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Um... Please read comment 9 again.

Comment 12

[Samir Gehani]

Boris,
I did.  I was pressed for time and had r, sr, and a when I checked in.  If
someone would like to fix this to use the pref that's fine by me.  I don't think
it is critical for the release of 0.9.9 personally.  

Comment 13

[sujay]

Boris, please verify...thanks..

Comment 14

[Boris Zbarsky [:bzbarsky]]

verified 2002-03-03 build.

Comment 15

[Roland Mainz]

Reopen to rework this one per comment #9 ...

Comment 16

[Roland Mainz]

Taking...

Comment 17

[Roland Mainz]

Attachment: Patch for 2002-03-06-08-trunk

The new patch now does the correct thing - it looks at the
"print.whileInPrintPreview" prefs item to decide whether we want the GUI or
not.

Comment 18

[Roland Mainz]

You can now enable/disable the GUI via setting
|user_pref("print.whileInPrintPreview", true);| in prefs.js

Comment 19

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 73418 [details] [diff] [review]
Patch for 2002-03-06-08-trunk

Please wrap the getBoolPref call in try/catch (and assume canPrint == true if
it fails).

Also |if(!canPrint)| is fine, no need to test == false.

Comment 20

[Roland Mainz]

Attachment: Better patch for 2002-03-06-08-trunk per bz's comments

Comment 21

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 73419 [details] [diff] [review]
Better patch for 2002-03-06-08-trunk per bz's comments

r=bzbarsky

Comment 22

[Roland Mainz]

Removing this bug from the "make 0.9.9 not suck radar for now" ...

Comment 23

[Marc Attinasi]

Comment on attachment 73419 [details] [diff] [review]
Better patch for 2002-03-06-08-trunk per bz's comments

sr=attinasi - do you really want to redeclare canPrint in the try block though?

Comment 24

[Roland Mainz]

Marc Attinasi wrote:
> (From update of attachment 73419 [details] [diff] [review])
> sr=attinasi
> do you really want to redeclare canPrint in the try block though?

Ouch. I'll file a fixed patch when my build is done...

Comment 25

[Roland Mainz]

Attachment: New patch for 2002-03-11-08-trunk per attinasi's superreview comment

Comment 26

[Roland Mainz]

Requesting a= ...

Comment 27

[Asa Dotzler [:asa]]

Comment on attachment 73812 [details] [diff] [review]
New patch for 2002-03-11-08-trunk per attinasi's superreview comment

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 28

[Roland Mainz]

Fix checked in, marking bug as FIXED (again) ... :)

Comment 29

[sujay]

verified.