Closed Bug 127699 Opened 22 years ago Closed 22 years ago

Disable UI for zoom, print, and landscape/postscript on Unix

Categories

(Core :: Print Preview, defect, P3)

Product:
Core
Component:
Print Preview
Platform:
All
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: bzbarsky, Assigned: roland.mainz)

References

Details

(Keywords: polish, useless-UI)

Attachments

(1 file, 3 obsolete files)

New patch for 2002-03-11-08-trunk per attinasi's superreview comment
1.20 KB, patch
asa
: approval+
Details | Diff | Splinter Review 
Once bug 127627 is fixed, zoom and landscape/portrait switching will no longer
work on Unix.  Printing from print preview already does not work (bug 126802).

Please disable the UI for this functionality on Unix for 0.9.9.  The current
state of affairs will look pretty unprofessional and, imo, will lead to slews of
bug reports like "When I click the arrow the number changes but the page does
not zoom!"
Keywords: mozilla0.9.9, polish
Nominating for us to take the interim measure.
Keywords: nsbeta1
Priority: -- → P3
Target Milestone: --- → mozilla0.9.9
Blocks: 122050
Where is the bug report to restore this funcationality?
Bug 127810 filed
Blocks: 127810
Whiteboard: [driver:asa]
Nav triage team: nsbeta1+
Keywords: nsbeta1 → nsbeta1+
Samir, this is going to cause a flood of bug reports. Are you going to be able
to get to this in thenext couple of days for 0.9.9?
Asa, I plan on coming up with a patch today.
r=law
sr=jag 

Changed to pass string "true" instead of boolean true in setAttribute() per
jag.
Changed to use appVersion instead of the customizable userAgent per law.
Attachment #71966 - Flags: needs-work+
Comment on attachment 71966 [details] [diff] [review]
Hide the print button, scaling widgets, and orientation widgets on Unices.

AFAIK we have a prefs which should control whether a printer device can have
more than one instance... I can't remember the name... rods ?

We should use that instead of |navigator.appVersion.indexOf("X11")| ...
Found it... it's (AFAIK) |pref("print.whileInPrintPreview", false);| we should
rely on... then it's easy to enable this later again...
a=asa

Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Um... Please read comment 9 again.
Boris,
I did.  I was pressed for time and had r, sr, and a when I checked in.  If
someone would like to fix this to use the pref that's fine by me.  I don't think
it is critical for the release of 0.9.9 personally.  
Boris, please verify...thanks..
verified 2002-03-03 build.
Status: RESOLVED → VERIFIED
Reopen to rework this one per comment #9 ...
Status: VERIFIED → REOPENED
Keywords: mozilla0.9.9, nsbeta1+
Resolution: FIXED → ---
Whiteboard: [driver:asa]
Target Milestone: mozilla0.9.9 → mozilla1.0
Taking...
Assignee: sgehani → Roland.Mainz
Status: REOPENED → NEW
Status: NEW → ASSIGNED
Attached patch Patch for 2002-03-06-08-trunk (obsolete) — — Splinter Review 
The new patch now does the correct thing - it looks at the
"print.whileInPrintPreview" prefs item to decide whether we want the GUI or
not.
Attachment #71966 - Attachment is obsolete: true
You can now enable/disable the GUI via setting
|user_pref("print.whileInPrintPreview", true);| in prefs.js
Keywords: patch, review
Comment on attachment 73418 [details] [diff] [review]
Patch for 2002-03-06-08-trunk

Please wrap the getBoolPref call in try/catch (and assume canPrint == true if
it fails).

Also |if(!canPrint)| is fine, no need to test == false.

        Attachment #73418 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 73419 [details] [diff] [review]
Better patch for 2002-03-06-08-trunk per bz's comments

r=bzbarsky

        Attachment #73419 -
        Flags: review+

    
    

    
  
Removing this bug from the "make 0.9.9 not suck radar for now" ...
No longer blocks: 122050

    
    

    
  
Comment on attachment 73419 [details] [diff] [review]
Better patch for 2002-03-06-08-trunk per bz's comments

sr=attinasi - do you really want to redeclare canPrint in the try block though?

        Attachment #73419 -
        Flags: superreview+

    
    

    
  
Marc Attinasi wrote:
> (From update of attachment 73419 [details] [diff] [review])
> sr=attinasi
> do you really want to redeclare canPrint in the try block though?

Ouch. I'll file a fixed patch when my build is done...

    
    

    
  
Requesting a= ...

    
    

    
  
Comment on attachment 73812 [details] [diff] [review]
New patch for 2002-03-11-08-trunk per attinasi's superreview comment

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

        Attachment #73812 -
        Flags: approval+

    
    

    
  
Fix checked in, marking bug as FIXED (again) ... :)
Status: ASSIGNED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED

    
    

    
  
verified.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.