1277041 - update migration scripts to support robustcheckout

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Jordan Lund (:jlund)]

11:55:42 <•rail> long term solution would be explicitly specifying the revision
11:56:30 <•rail> maybe hardcode the current revisions into configs?
11:56:58 <•rail> so you don't need to backout that change?
12:01:48 <•jlund> hm .. k I'll hard code tips of each and I guess long term is copying https://hg.mozilla.org/build/tools/file/default/buildfarm/utils/archiver_client.py#l284
12:03:12 <•rail> yeah

Comment 1

[Jordan Lund (:jlund)]

Attachment: MozReview Request: Bug 1277041 - add unique hg share option and rev in push with migration runs, r?gps

Review commit: https://reviewboard.mozilla.org/r/56642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56642/

Comment 2

[Jordan Lund (:jlund)]

(In reply to Jordan Lund (:jlund) from comment #0)
> 11:55:42 <•rail> long term solution would be explicitly specifying the
> revision
> 11:56:30 <•rail> maybe hardcode the current revisions into configs?
> 11:56:58 <•rail> so you don't need to backout that change?
> 12:01:48 <•jlund> hm .. k I'll hard code tips of each and I guess long term
> is copying
> https://hg.mozilla.org/build/tools/file/default/buildfarm/utils/
> archiver_client.py#l284
> 12:03:12 <•rail> yeah

aborting this plan since we can reliably use --branch default instead of --revision $rev

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8758405 [details]
MozReview Request: Bug 1277041 - add unique hg share option and rev in push with migration runs, r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56642/diff/1-2/

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8758405 [details]
MozReview Request: Bug 1277041 - add unique hg share option and rev in push with migration runs, r?gps

https://reviewboard.mozilla.org/r/56642/#review53320

Much better than my version :)

Comment 5

[Jordan Lund (:jlund)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/092c8795c47a04bb8fd96499847198537c144258
Bug 1277041 - update migration scripts to support robustcheckout, DONTBUILD r=gps

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8758405 [details]
MozReview Request: Bug 1277041 - add unique hg share option and rev in push with migration runs, r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56642/diff/2-3/

Comment 8

[Jordan Lund (:jlund)]

(In reply to Jordan Lund (:jlund) from comment #7)
> Comment on attachment 8758405 [details]
> MozReview Request: Bug 1277041 - add unique hg share option and rev in push
> with migration runs, r?gps
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/56642/diff/2-3/

hm, this is why I create new bugs for follow ups :)

not sure what I did wrong but this is a new changeset for same bug summary: https://reviewboard.mozilla.org/r/56642/diff/3#index_header

it's fine if you don't want me to land this but I wanted to post a solution up so merge folks can apply it locally if need be.

Comment 9

[Axel Hecht [:Pike]]

Note, we still do relbranches for mobile. No idea about thunderbird or seamonkey, don't even find tags for them.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/092c8795c47a

Comment 11

[Jordan Lund (:jlund)]

(In reply to Axel Hecht [:Pike] from comment #9)
> Note, we still do relbranches for mobile. No idea about thunderbird or
> seamonkey, don't even find tags for them.

oh, right! hm, I guess I'm not sure what we should be expecting with migrations.

checking m-r current branches, it looks like we stopped migrating android beta branches after gecko 44.0: https://hg.mozilla.org/releases/mozilla-release/branches

not sure if that is expected..

Comment 12

[Jordan Lund (:jlund)]

(In reply to Jordan Lund (:jlund) from comment #8)
> (In reply to Jordan Lund (:jlund) from comment #7)
> > Comment on attachment 8758405 [details]
> > MozReview Request: Bug 1277041 - add unique hg share option and rev in push
> > with migration runs, r?gps
> > 
> > Review request updated; see interdiff:
> > https://reviewboard.mozilla.org/r/56642/diff/2-3/
> 
> hm, this is why I create new bugs for follow ups :)
> 
> not sure what I did wrong but this is a new changeset for same bug summary:
> https://reviewboard.mozilla.org/r/56642/diff/3#index_header
> 
> it's fine if you don't want me to land this but I wanted to post a solution
> up so merge folks can apply it locally if need be.

see above mozreview noob moves..

Comment 13

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/56642/#review54412

Yeah, this hack will work. Ugly, but it works.

Comment 14

[Gregory Szorc [:gps]]

Not sure what the needinfo is for.

Comment 15

[Jordan Lund (:jlund)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ec243446e6d3afe0c60842b5aaddc699bf7a069
Bug 1277041 - add unique hg share option and rev in push with migration runs, DONTBUILD r=gps

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1ec243446e6d

Comment 17

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.