127784 - Require restart on theme switch

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P1)

Description

[Michael Buckland]

Discussed in 2/25/2002 ADT mtng.  Decision was to require restart on theme
switch.  See also Bugzilla 124009 and 124205

Comment 1

[Christine Hoffman]

Changing QA contact

Comment 2

[rubydoo123]

Changing component to preferences and reassigning.

Comment 3

[Samir Gehani]

-> Themes per pref ownership model

Comment 4

[Paul Wyskoczka]

Patty should probably qa this change.

Comment 5

[Samir Gehani]

Meant to reassign to Themes owner.

Comment 6

[Jaime Rodriguez, Jr.]

Removing *crash* keyword, as this bug is not specifically about a crash, but a
request to require Theme Switching to require a restart.

Comment 7

[Peter Trudelle]

*** Bug 128168 has been marked as a duplicate of this bug. ***

Comment 8

[Peter Trudelle]

nsbeta1+ per Nav triage team

Comment 9

[Joe Hewitt (gone)]

BOOHOO!! :( ah well, it was fun while it lasted

Comment 10

[Blake Ross]

since I was given bug 128168, I'll take this one...

Comment 11

[Sören 'Chucker' Kuklau (gone)]

How about adding an option in debug prefs?

[ ] Enable dynamic theme switching (no required restart)

Off by default.

That way, hewitt will continue to have fun with it.

Comment 12

[Lorenzo Colitti]

> [ ] Enable dynamic theme switching (no required restart)

Ack! This is the coolest feature in 0.9.8. :-)

Comment 13

[Blake Ross]

Attachment: patch

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 73479 [details] [diff] [review]
patch

I'd insist on a pref if this worked most of the time on the trunk... but it
almost always crashes on me (or crashes shortly after switching). 

Also, blake assures me the drag handler stuff is part of a separate bug, so my
sr=[e-mail] applies to all other parts of the patch.

Comment 15

[Hixie (not reading bugmail)]

After 1.0 we should dedicate an entire milestone to making dynamic skin
switching work perfectly. It's getting a little tedious the way we disable it
before any major release.

Comment 16

[Peter Trudelle]

Not a chance. What's tedious is that we keep enabling it and having critical
regressions.  What we should really do is dump skin switching entirely, it isn't
worth the cost.

Comment 17

[Syd Logan]

blake, can you get an r= on this? let me know if not, i can help you.

Comment 18

[Joe Hewitt (gone)]

Comment on attachment 73479 [details] [diff] [review]
patch

r=me

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 73479 [details] [diff] [review]
patch

a=dbaron for trunk checkin.

I would like to note (in response to comment 16) that many of the crashes right
now are probably due to a single problem, the one described in bug 121055.  The
new implementation of theme switching (since it was turned back on) should be a
good bit safer than the old one.  It's just there were some details wrong...

Comment 20

[Peter Trudelle]

Blake, would you like someone else to take this?

Comment 21

[Blake Ross]

fixed.

Comment 22

[Robert Kaiser]

Another very cool feature dying entirely?

Comment 23

[Shawn Neumann]

What happens if you have a couple of different profiles you are accessing
through the quickload feature and each profile uses a different skin?  Will
having to restart the app impact the ability to switch between profiles with
Mozilla staying in memory?

That would be a drag.

Comment 24

[Patty Mac]

Verified on all platforms (commecial netscape build: 2002-03-25-08-TRUNK). While 
switching themes, a dialog should pop up like this
"Theme changes will take effect when you restart Netscape 6".

Comment 25

[John S. Musarra]

Okay, I just read through what I think are all applicable bugs, so hopefully
I'll sound less ignorant that I really am... I miss dynamic theme switching! It
is a great feature, and, incidentally, one that I never had any problems with
(that I know about, anyway). Having to restart the browser every time I change
my theme, which is something that happens fairly often, is getting to be a royal
pain in the butt. Thanks to tabs, I now have not just one web page open that I
need to bookmark and come back to, but potentially *many*. The "Bookmark this
group of tabs" feature goes a long way toward alleviating some of this
annoyance, but not far enough.
Basically, what I'm saying is - bring back dynamic theme switching! If there are
problems with it, fix 'em! I know that there's lots of other things on mozilla
org's to-do list, I'm just asking that this be one of them. Okay, thanks!