1278901 - Non-selectable text added to svg with javascript is initially selected

Status: RESOLVED WORKSFORME

(Core :: SVG, defect, P3)

Description

[shao.lo]

Attachment: test.htm

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160511223818

Steps to reproduce:

When I add a text node to my document in response to a click it is sometimes selected/highlighted initially.  The text is supposed to be unselectable.




Actual results:

With the attached html file, when I click outside the red rect the text is added correctly (without being selected).

When I click inside the red rect the text appears selected. After clicking anywhere, the selection is removed and the text can no longer be selected.



Expected results:

The text should be added unselected (and unselectable) regardless of where the click is received.

Comment 1

[Loic]

Regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cbb24a4a96af&tochange=d7553251cf43

Probably due to: Cameron McCormack — Bug 839955 - Enable new SVG text frames. r=roc

Comment 2

[shao.lo]

Was in 46.01.1 as well (Windows and Ubuntu Linux)

Comment 3

[Astley Chen (inactive)]

Reproduced on Nightly56 and Beta55.
The problem only appeared when we click into red rect area.

Comment 4

[Louis Chang [:louis]]

Attachment: testcase2

So this bug is not svg specific. In the test case, if you select all (ctrl+a) before the <div> element is inserted. The div with style -moz-user-select: none will still be selected as well.

Comment 5

[Louis Chang [:louis]]

Attachment: Bug 1278901 - Check whether mUserSelect of parent frame is none before painting the selection.

Review commit: https://reviewboard.mozilla.org/r/190920/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190920/

Comment 6

[Louis Chang [:louis]]

Comment on attachment 8919976 [details]
Bug 1278901 - Check whether mUserSelect of parent frame is none before painting the selection.

Hi CJ,

Could you give a feedback on the patch?

Basically I just add a check of whether mUserSelect of the parent frame is none before painting the selection. Since the property -moz-user-select is not inherited.

Although, I'm not sure why currently the selection is broken only if we insert an element with -moz-user-select:none afterward.

Comment 7

[Louis Chang [:louis]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5a6fdceaa504356a7180c9719759dd19dec575f

Comment 8

[u459114]

Comment on attachment 8919976 [details]
Bug 1278901 - Check whether mUserSelect of parent frame is none before painting the selection.

ShouldDrawSelection is used by nsTextFrame::PaintText, so you will only change rendering part of "user-select". I think you probably should check why PaintTextWithSelection contains selection range in this test case

Comment 9

[Robert Longson [:longsonr]]

Seems OK now.