1279238 - Make "good first bug" a keyword instead of a whiteboard tag

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task, P3)

Description

[:Gijs (he/him)]

Because all the "good-first-bug", "[good first bug]", "[good-first-bug]" and "good first bug" alternatives are silly. We should settle on something and use a keyword. Paging :jdm and :mhoye as I expect they have, like, opinions, on this stuff (or software to update if we do this and mass-change bugs).

Comment 1

[David Lawrence [:dkl]]

We will need a description for the keyword as well.

Comment 2

[Josh Matthews [:jdm]]

I'm happy with "good first bug" if that's acceptable as a keyword. Where do keyword descriptions appear so I can find some good models?

Comment 3

[David Lawrence [:dkl]]

(In reply to Josh Matthews [:jdm] from comment #2)
> I'm happy with "good first bug" if that's acceptable as a keyword. Where do
> keyword descriptions appear so I can find some good models?

https://bugzilla.mozilla.org/describekeywords.cgi

Comment 4

[:Gijs (he/him)]

(In reply to Josh Matthews [:jdm] from comment #2)
> I'm happy with "good first bug" if that's acceptable as a keyword. Where do
> keyword descriptions appear so I can find some good models?

https://bugzilla.mozilla.org/describekeywords.cgi

How about:

An entry-level bug that has guidance to help people make their first contribution to Mozilla.

or something like that?

Comment 5

[Josh Matthews [:jdm]]

Works for me!

Comment 6

[Mike Hoye [:mhoye]]

Tempted to bikeshed the text, but no. That's perfectly good, I second.

Comment 7

[David Lawrence [:dkl]]

 The keyword good-first-bug has been created. Leaving bug open once script is ready to migrate from whiteboard to keyword.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Does this mean that the language descriptor e.g. [lang=js] will remain a whiteboard tag?

Comment 9

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #8)
> Does this mean that the language descriptor e.g. [lang=js] will remain a
> whiteboard tag?

Yes, we're just moving [good first bug] and variants. Can you tell me more about how you're using [lang=*]?

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Emma Humphries ☕️ [:emceeaich] (UTC-8) +needinfo me from comment #9)
> (In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #8)
> > Does this mean that the language descriptor e.g. [lang=js] will remain a
> > whiteboard tag?
> 
> Yes, we're just moving [good first bug] and variants. Can you tell me more
> about how you're using [lang=*]?

Historically it's been used to mark [lang=js], [lang=css], etc. for the "bugs ahoy" tool[1] for new contributors.  It allows filtering on whether the bug requires JS, CSS, etc. knowledge to complete and uses these tags to filter.

For the DevTools team specifically, we now have our own specialized bug finder[2] that doesn't currently make use of the `lang` portion of the whiteboard data, so it's unclear if our team actually cares about it (though we do still set the lang whiteboard tag sporadically out of habit).

As for updating the DevTools bug finder for this change to a good-first-bug keyword, I filed an issue[3] about this.

[1]: http://www.joshmatthews.net/bugsahoy/
[2]: http://firefox-dev.tools/
[3]: https://github.com/captainbrosset/devtools-bug-finder/issues/22

Comment 11

[Dylan Hardison [:dylan] (he/him)]

metadata like that is fine in the whiteboard. The switch to keywords is largely a search optimization. I imagine that bugsahoy and co fetch their list of bugs and process the whiteboard status file to differentiate bugs.

Comment 12

[Mark Côté [:mcote]]

FYI this is an example of a search that Bugs Ahoy does (with "Release Engineering" and "Python" checked):

https://bugzilla.mozilla.org/bzapi/bug?f1=bug_mentor&o1=isnotempty&whiteboard_type=contains_all&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=UNCONFIRMED&include_fields=id&include_fields=assigned_to&include_fields=summary&include_fields=last_change_time&include_fields=component&include_fields=whiteboard&product=%20Release%20Engineering

Adding "good first bug" results in (oddly omitting the product now, despite it being still checked) https://bugzilla.mozilla.org/bzapi/bug?f1=bug_mentor&o1=isnotempty&whiteboard_type=contains_all&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=UNCONFIRMED&include_fields=id&include_fields=assigned_to&include_fields=summary&include_fields=last_change_time&include_fields=component&include_fields=whiteboard&product=&status_whiteboard=good%20first%20bug

Comment 13

[Sebastian Zartner [:sebo]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #10)
> [2]: http://firefox-dev.tools/

How do people get to know about that page? It should at least be linked to from https://developer.mozilla.org/en-US/docs/Tools.

Sebastian

Comment 14

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

What component is http://firefox-dev.tools/ in and who's responsible for it?

Comment 15

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Sebastian Zartner [:sebo] from comment #13)
> (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #10)
> > [2]: http://firefox-dev.tools/
> 
> How do people get to know about that page? It should at least be linked to
> from https://developer.mozilla.org/en-US/docs/Tools.

It's currently linked on our getting involved[1] wiki page.

[1]: https://wiki.mozilla.org/DevTools/GetInvolved#Mentored_and_Good_First_Bugs

Comment 16

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Emma Humphries ☕️ [:emceeaich] (UTC-8) +needinfo me from comment #14)
> What component is http://firefox-dev.tools/ in and who's responsible for it?

It is managed by DevTools team, but it doesn't really have a component of it's own.  The project is on GitHub and I have filed an issue[1] about this keyword there (as I mentioned in comment 10 above).

Maybe it's better to move bug 1294824 to Firefox :: DevTools, or close it and link to the GitHub issue?  DevTools team doesn't watch the Websites product.

[1]: https://github.com/captainbrosset/devtools-bug-finder/issues/22

Comment 17

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #16)

> Maybe it's better to move bug 1294824 to Firefox :: DevTools, or close it
> and link to the GitHub issue?  DevTools team doesn't watch the Websites
> product.

I closed bug 1294824 as incomplete.

Comment 18

[Sebastian Zartner [:sebo]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #15)
> (In reply to Sebastian Zartner [:sebo] from comment #13)
> > (In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #10)
> > > [2]: http://firefox-dev.tools/
> > 
> > How do people get to know about that page? It should at least be linked to
> > from https://developer.mozilla.org/en-US/docs/Tools.
> 
> It's currently linked on our getting involved[1] wiki page.
> 
> [1]:
> https://wiki.mozilla.org/DevTools/GetInvolved#Mentored_and_Good_First_Bugs

I've also added a new section 'Contribute' to the main DevTools MDN page[1] and mentioned it at a few other places[2][3].

Sebastian

[1] https://developer.mozilla.org/en-US/docs/Tools#Contribute
[2] https://developer.mozilla.org/en-US/docs/Mozilla/Mozilla_on_GitHub
[3] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Using_the_VM

Comment 19

[Dylan Hardison [:dylan] (he/him)]

We have had the keyword for a while, I'm closing this bug as I don't imagine any further work needs to be tracked here.

Comment 20

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

We still need to take the bugs with "good-first-bug" in the whiteboard and move them to this keyword. :dkl has a script to do this.

Comment 21

[Dylan Hardison [:dylan] (he/him)]

this cannot be done until keyword search scale-able.

Comment 22

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

(In reply to Dylan Hardison [:dylan] (he/him) from comment #21)
> this cannot be done until keyword search scale-able.

What's the bug for the keyword search work? It should be a dependency.

Comment 23

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Since Elasticsearch bypasses this problem, should we do the remapping step or wait?

Comment 24

[Dylan Hardison [:dylan] (he/him)]

it doesn't matter to me.

Comment 25

[Kohei Yoshino [:kohei]]

There are still 4900+ bugs having [good first bug] in the whiteboard.

Comment 26

[Kohei Yoshino [:kohei]]

And it’s still mentioned in the BMO User Guide.

Comment 27

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Removed from user guide.

Comment 28

[Kohei Yoshino [:kohei]]

For open bugs, replaced [good-first-bug] and similar terms in whiteboard with the good-first-bug keyword. Closing.

Comment 29

[Rainer Bielefeld]

For future please find a way to do such modifications without flooding volunteers' mailboxes with lots of lots of notifications concerning changes in "their" Bugs.