1280131 - Browser tabs in Linux use low rez assets on hidpi displays

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Eitan Isaacson [:eeejay]]

The pretty Australis curves are fuzzy in Linux!

It looks like the pre-Win10 assets are identical to Linux. I'll just copy them over and update the CSS..

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1280131 - Add tabbrowser hidpi assets in Linux.

Review commit: https://reviewboard.mozilla.org/r/59250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/59250/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8762770 [details]
Bug 1280131 - Add tabbrowser hidpi assets in Linux.

https://reviewboard.mozilla.org/r/59250/#review56308

Again, we should unify this - this time in in tabs.inc.css .

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 8762770 [details]
Bug 1280131 - Add tabbrowser hidpi assets in Linux.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59250/diff/1-2/

Comment 4

[:Gijs (he/him)]

Comment on attachment 8762770 [details]
Bug 1280131 - Add tabbrowser hidpi assets in Linux.

https://reviewboard.mozilla.org/r/59250/#review56524

::: browser/themes/linux/jar.mn:101
(Diff revision 2)
>    skin/classic/browser/social/share-button.png        (social/share-button.png)
>    skin/classic/browser/social/share-button-active.png (social/share-button-active.png)
>    skin/classic/browser/tabbrowser/alltabs.png         (tabbrowser/alltabs.png)
>    skin/classic/browser/tabbrowser/alltabs-inverted.png (tabbrowser/alltabs-inverted.png)
>    skin/classic/browser/tabbrowser/connecting.png      (tabbrowser/connecting.png)
> +  skin/classic/browser/tabbrowser/[e-mail]      (tabbrowser/[e-mail])

Nit: here and below please ensure the (source) items you're adding line up with the ones below/above them as much as possible.

::: browser/themes/shared/tabs.inc.css:479
(Diff revision 2)
>  .tabs-newtab-button {
>    width: calc(36px + @tabCurveWidth@);
>  }
> +
> +@media (min-resolution: 1.1dppx) {
> +  /* image preloading hack from shared/tabs.inc.css */

Nit: update this comment to something like "image preloading hack like for lodpi"?

::: browser/themes/windows/browser.css:1954
(Diff revision 2)
>    .tab-throbber[progress] {
>      list-style-image: url("chrome://global/skin/icons/[e-mail]");
>    }

Can you file a followup bug to unify this and have the @2x version on Linux as well?

Comment 5

[Eitan Isaacson [:eeejay]]

https://reviewboard.mozilla.org/r/59250/#review56524

> Can you file a followup bug to unify this and have the @2x version on Linux as well?

Bug 1280510.

Comment 6

[Eitan Isaacson [:eeejay]]

Comment on attachment 8762770 [details]
Bug 1280131 - Add tabbrowser hidpi assets in Linux.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59250/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c79e0eb26143
Add tabbrowser hidpi assets in Linux. r=Gijs

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c79e0eb26143

Comment 9

[Marco Castelluccio [:marco]]

Is it expected that on Linux I'm not seeing the orange loading throbber anymore?