Closed Bug 1280131 Opened 4 years ago Closed 4 years ago

Browser tabs in Linux use low rez assets on hidpi displays

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The pretty Australis curves are fuzzy in Linux!

It looks like the pre-Win10 assets are identical to Linux. I'll just copy them over and update the CSS..
Attachment #8762770 - Flags: review?(gijskruitbosch+bugs) → review-
Comment on attachment 8762770 [details]
Bug 1280131 - Add tabbrowser hidpi assets in Linux.

https://reviewboard.mozilla.org/r/59250/#review56308

Again, we should unify this - this time in in tabs.inc.css .
Comment on attachment 8762770 [details]
Bug 1280131 - Add tabbrowser hidpi assets in Linux.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59250/diff/1-2/
Attachment #8762770 - Flags: review- → review?(gijskruitbosch+bugs)
Attachment #8762770 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8762770 [details]
Bug 1280131 - Add tabbrowser hidpi assets in Linux.

https://reviewboard.mozilla.org/r/59250/#review56524

::: browser/themes/linux/jar.mn:101
(Diff revision 2)
>    skin/classic/browser/social/share-button.png        (social/share-button.png)
>    skin/classic/browser/social/share-button-active.png (social/share-button-active.png)
>    skin/classic/browser/tabbrowser/alltabs.png         (tabbrowser/alltabs.png)
>    skin/classic/browser/tabbrowser/alltabs-inverted.png (tabbrowser/alltabs-inverted.png)
>    skin/classic/browser/tabbrowser/connecting.png      (tabbrowser/connecting.png)
> +  skin/classic/browser/tabbrowser/connecting@2x.png      (tabbrowser/connecting@2x.png)

Nit: here and below please ensure the (source) items you're adding line up with the ones below/above them as much as possible.

::: browser/themes/shared/tabs.inc.css:479
(Diff revision 2)
>  .tabs-newtab-button {
>    width: calc(36px + @tabCurveWidth@);
>  }
> +
> +@media (min-resolution: 1.1dppx) {
> +  /* image preloading hack from shared/tabs.inc.css */

Nit: update this comment to something like "image preloading hack like for lodpi"?

::: browser/themes/windows/browser.css:1954
(Diff revision 2)
>    .tab-throbber[progress] {
>      list-style-image: url("chrome://global/skin/icons/loading@2x.png");
>    }

Can you file a followup bug to unify this and have the @2x version on Linux as well?
https://reviewboard.mozilla.org/r/59250/#review56524

> Can you file a followup bug to unify this and have the @2x version on Linux as well?

Bug 1280510.
Comment on attachment 8762770 [details]
Bug 1280131 - Add tabbrowser hidpi assets in Linux.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59250/diff/2-3/
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c79e0eb26143
Add tabbrowser hidpi assets in Linux. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/c79e0eb26143
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Is it expected that on Linux I'm not seeing the orange loading throbber anymore?
Depends on: 1282168
You need to log in before you can comment on or make changes to this bug.